Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue #291 #292

Merged
merged 1 commit into from
May 17, 2024
Merged

Fix issue #291 #292

merged 1 commit into from
May 17, 2024

Conversation

lohedges
Copy link
Contributor

This PR closes #291 and closes OpenBioSim/sire#197.

  • I confirm that I have merged the latest version of devel into this branch before issuing this pull request (e.g. by running git pull origin devel): [y]
  • I confirm that I have permission to release this code under the GPL3 license: [y]

Suggested reviewers:

@nigel-palmer-cresset

@lohedges lohedges added bug Something isn't working cresset Related to work with Cresset labels May 17, 2024
@lohedges lohedges temporarily deployed to biosimspace-build May 17, 2024 10:11 — with GitHub Actions Inactive
@lohedges lohedges temporarily deployed to biosimspace-build May 17, 2024 10:11 — with GitHub Actions Inactive
@lohedges lohedges had a problem deploying to biosimspace-build May 17, 2024 10:11 — with GitHub Actions Failure
@lohedges lohedges temporarily deployed to biosimspace-build May 17, 2024 10:11 — with GitHub Actions Inactive
@lohedges lohedges temporarily deployed to biosimspace-build May 17, 2024 10:11 — with GitHub Actions Inactive
nigel-palmer-cresset
nigel-palmer-cresset approved these changes May 17, 2024
View reviewed changes
Copy link

@nigel-palmer-cresset nigel-palmer-cresset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has fixed the problems I was having. Thank you for the quick fix.

@lohedges
Copy link
Contributor Author

No problem. Thanks for confirming.

@lohedges lohedges merged commit 598a674 into devel May 17, 2024
4 of 5 checks passed
@lohedges lohedges deleted the fix_291 branch May 17, 2024 15:11
lohedges added a commit that referenced this pull request May 17, 2024
@lohedges
Backport fixes from PR #292. [ci skip]
22d8b7c
@lohedges lohedges mentioned this pull request May 17, 2024
Merged
lohedges added a commit that referenced this pull request May 20, 2024
@lohedges
Merge pull request #293 from OpenBioSim/backport_292
90c2d0f 
Backport fixes from PR #292
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nigel-palmer-cresset nigel-palmer-cresset nigel-palmer-cresset approved these changes

Assignees
No one assigned
Labels
bug Something isn't working cresset Related to work with Cresset
Projects
None yet
Milestone
No milestone
2 participants
@lohedges @nigel-palmer-cresset