Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: copy ItemOwnZValue when cloning item #1174

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

letsfindaway
Copy link
Collaborator

This PR should fix #1167

  • for most items, only zValue was copied when cloning
  • now also copy the ItemOwnZValue data property

Notes:

  • It could also be an idea to use UBGraphicsItem::assignZValue() in these cases. which assigns a z value to both, the data property and the item itself. However I'm not sure whether these values could differ while cloning.
  • As the z value is something common to all items, we could also extract copying of this parameter to a base class. However I did not want to introduce such a change here without discussion. There are possibly other such common parameters which should be copied for all item types.

- for most items, only zValue was copied when cloning
- also copy the ItemOwnZValue data property
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant