FEMS Backports 2025-01-20 #2976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- replace locale being overwritten with browserlang to be using the user lang - fix czech locale, `cz` throwing errors for - piping (using angular pipes) - formatting of numbers replacing it with `cs` -> [Ref](https://github.com/angular/common-builds/blob/main/locales/global/cs.js) <hr/> Co-authored-by: Anas Shetla <[email protected]> Reviewed-by: Anas Shetla <[email protected]> Reviewed-by: Stefan Feilmeier <[email protected]> Co-authored-by: Lukas Rieger <[email protected]> Co-committed-by: Lukas Rieger <[email protected]>
- fixes name of channel in ModbusTCP widget (e.g. Ess1SetActivePowerEquals was shown as SetActivePowerEquals/706 in OM) - Several ess lead to repeating register names in ModbusTcp widget. Reviewed-by: Lukas Rieger <[email protected]> Reviewed-by: Stefan Feilmeier <[email protected]> Co-authored-by: Fabian Brandtner <[email protected]> Co-committed-by: Fabian Brandtner <[email protected]>
Enhancing styles of popover in accordance with dark-mode feature. Reviewed-by: Lukas Rieger <[email protected]> Reviewed-by: Stefan Feilmeier <[email protected]> Co-authored-by: Anas Shetla <[email protected]> Co-committed-by: Anas Shetla <[email protected]>
- Migrate Switch-Case-Expressions to Switch-Case-Statements - UI: Fix FactoryId `Controller.IO.Heating.Room` - General code cleanup (using Eclipse "Clean up" tool) Co-authored-by: Michael Grill <[email protected]> Reviewed-by: Michael Grill <[email protected]>
Remove invalid code Co-authored-by: Sebastian Asen <[email protected]> Co-authored-by: Christian Lehne <[email protected]> Co-authored-by: Stefan Feilmeier <[email protected]> Reviewed-by: Christian Lehne <[email protected]> Reviewed-by: Sebastian Asen <[email protected]> Reviewed-by: Stefan Feilmeier <[email protected]> Co-authored-by: Thomas Sicking <[email protected]> Co-committed-by: Thomas Sicking <[email protected]>
Codecov ReportAttention: Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #2976 +/- ##
=============================================
+ Coverage 56.85% 57.03% +0.19%
- Complexity 9800 9810 +10
=============================================
Files 2281 2279 -2
Lines 97624 97389 -235
Branches 7208 7055 -153
=============================================
+ Hits 55491 55537 +46
+ Misses 40047 39809 -238
+ Partials 2086 2043 -43 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UI
czthrowing errors forcs-> RefController.IO.Heating.RoomEdge
Co-authored-by: Anas Shetla [email protected]
Co-authored-by: Lukas Rieger [email protected]
Co-authored-by: Fabian Brandtner [email protected]
Co-authored-by: Michael Grill [email protected]
Co-authored-by: Sebastian Asen [email protected]
Co-authored-by: Christian Lehne [email protected]
Co-authored-by: Stefan Feilmeier [email protected]
Co-authored-by: Thomas Sicking [email protected]