Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update accessibilty #91

Merged
merged 4 commits into from
Nov 25, 2024
Merged

Update accessibilty #91

merged 4 commits into from
Nov 25, 2024

Conversation

jguo144
Copy link
Collaborator

@jguo144 jguo144 commented Nov 19, 2024 •
edited
Loading

Description

  • Update label on new user form to "Confirm Password" rather than just "Confirm"
  • Add JS to close popover with escape button
  • Add JS to keep focus on modal when it's displayed
  • Move script snippet to below footer tag

orca-security-us[bot]
orca-security-us bot reviewed Nov 19, 2024
View reviewed changes
Copy link

@orca-security-us orca-security-us bot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Infrastructure as Code high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Vulnerabilities high 0   medium 0   low 0   info 0 View in Orca

@jguo144 jguo144 marked this pull request as ready for review November 19, 2024 22:55
@jguo144 jguo144 marked this pull request as draft November 19, 2024 23:41
scastineyras
scastineyras previously approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@scastineyras scastineyras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jguo144 jguo144 force-pushed the jguo144/2024-11-19/update-a11y branch from 6e82d42 to f663e86 Compare November 22, 2024 21:55
@jguo144 jguo144 force-pushed the jguo144/2024-11-19/update-a11y branch from f663e86 to 65ea698 Compare November 22, 2024 22:35
@jguo144 jguo144 marked this pull request as ready for review November 22, 2024 22:36
@jguo144 jguo144 enabled auto-merge (squash) November 22, 2024 22:38
scastineyras
scastineyras approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@scastineyras scastineyras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jguo144 jguo144 merged commit b5bc582 into master Nov 25, 2024
5 checks passed
@jguo144 jguo144 deleted the jguo144/2024-11-19/update-a11y branch November 25, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orca-security-us orca-security-us[bot] orca-security-us[bot] left review comments

@scastineyras scastineyras scastineyras approved these changes

@peterVorman peterVorman Awaiting requested review from peterVorman

Assignees

@peterVorman peterVorman

@scastineyras scastineyras

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jguo144 @scastineyras @peterVorman