Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move footer_script_snippet helper function #92

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

jguo144
Copy link
Collaborator

@jguo144 jguo144 commented Dec 5, 2024

Description

Move footer_script_snippet helper function to the opengov_custom_theme plugin from the opengov_custom_footer plugin. The footer_script_snippet helper function is called in a template in opengov_custom_theme, not opengov_custom_footer.

@jguo144 jguo144 marked this pull request as ready for review December 5, 2024 19:11
Copy link

@orca-security-us orca-security-us bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Infrastructure as Code high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Vulnerabilities high 0   medium 0   low 0   info 0 View in Orca

Copy link
Collaborator Author

@jguo144 jguo144 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jguo144 jguo144 closed this Dec 5, 2024
@jguo144 jguo144 force-pushed the jguo144/2024-12-05/move-helper-function branch from 95a644e to b5bc582 Compare December 5, 2024 19:25
@jguo144 jguo144 reopened this Dec 5, 2024
@jguo144 jguo144 merged commit c433279 into master Dec 5, 2024
7 checks passed
@jguo144 jguo144 deleted the jguo144/2024-12-05/move-helper-function branch December 5, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant