-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update SB3 WAR post to highlight use of Spring Boot application props #4227
base: staging
Are you sure you want to change the base?
Conversation
Signed-off-by: Scott Kurz <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a minor edit suggestion and fix for formatting in the existing post
posts/2024-05-01-spring-boot-3.adoc
Outdated
server.servlet.context-path=/testpath | ||
---- | ||
+ | ||
4. You can also configure the application using `server.xml`. To illustrate, we'll set a Spring Boot property as an application argument in the Liberty `server.xml` configuration file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4. You can also configure the application using `server.xml`. To illustrate, we'll set a Spring Boot property as an application argument in the Liberty `server.xml` configuration file. | |
4. You can also configure the application in the Liberty `server.xml` file by setting a Spring Boot property as an application argument. The following example sets the logging level for the application. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this overall and made a very minor tweak on top of it in 4548478
Signed-off-by: Scott Kurz <[email protected]>
Co-authored-by: David Mueller <[email protected]>
11adb78
to
1e96d26
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - please also commit the revisions back to the draft
branch- Thanks!
Continuing #4221