Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SB3 WAR post to highlight use of Spring Boot application props #4227

Open
wants to merge 3 commits into
base: staging
Choose a base branch
from

Conversation

scottkurz
Copy link
Member

Continuing #4221

@scottkurz scottkurz requested a review from dmuelle January 21, 2025 21:45
Copy link
Member

@dmuelle dmuelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a minor edit suggestion and fix for formatting in the existing post

server.servlet.context-path=/testpath
----
+
4. You can also configure the application using `server.xml`. To illustrate, we'll set a Spring Boot property as an application argument in the Liberty `server.xml` configuration file.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
4. You can also configure the application using `server.xml`. To illustrate, we'll set a Spring Boot property as an application argument in the Liberty `server.xml` configuration file.
4. You can also configure the application in the Liberty `server.xml` file by setting a Spring Boot property as an application argument. The following example sets the logging level for the application.

Copy link
Member Author

@scottkurz scottkurz Jan 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this overall and made a very minor tweak on top of it in 4548478

posts/2024-05-01-spring-boot-3.adoc Outdated Show resolved Hide resolved
scottkurz and others added 2 commits January 22, 2025 15:15
Copy link
Member

@dmuelle dmuelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - please also commit the revisions back to the draft branch- Thanks!

@scottkurz scottkurz mentioned this pull request Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants