Bump braces and gulp

[dependabot]

Bumps braces to 3.0.3 and updates ancestor dependency gulp. These dependencies need to be updated together.

Updates braces from 3.0.2 to 3.0.3

Commits

• 74b2db2 3.0.3
• 88f1429 update eslint. lint, fix unit tests.
• 415d660 Snyk js braces 6838727 (#40)
• 190510f fix tests, skip 1 test in test/braces.expand
• 716eb9f readme bump
• a5851e5 Merge pull request #37 from coderaiser/fix/vulnerability
• 2092bd1 feature: braces: add maxSymbols (https://github.com/micromatch/braces/issues/...
• 9f5b4cf fix: vulnerability (https://security.snyk.io/vuln/SNYK-JS-BRACES-6838727)
• 98414f9 remove funding file
• 665ab5d update keepEscaping doc (#27)
• Additional commits viewable in compare view

Updates gulp from 4.0.2 to 5.0.0

Release notes

Sourced from gulp's releases.

gulp v5.0.0

We've tried to provide a high-level changelog for gulp v5 below, but it doesn't contain all changes from the 60+ dependencies that we maintain.

Please see individual changelogs to drill down into all changes that were made.

⚠ BREAKING CHANGES

• Drop support for Node.js <10.13
• Default stream encoding to UTF-8
• Standardized on anymatch library for globbing paths. All globs should work the same between src and watch now!
• Removed support for ordered globs. This aligns with the chokidar globbing implementation. If you need your globs to be ordered, you can use ordered-read-stream
• All globs and paths are normalized to unix-like filepaths
• Only allow JS variants for .gulp.* config files
• Removed support for alpha releases of v4 from gulp-cli
• Removed the --verify flag
• Renamed the --require flag to --preload to avoid conflicting with Node.js flags
• Removed many legacy and deprecated loaders
• Upgrade to chokidar v3
• Clone Vinyl objects with stream contents using teex, but no longer wait for all streams to flow before cloned streams will receive data
• Stop using process.umask() to make directories, instead falling back to Node's default mode
• Throw on non-function, non-string option coercers
• Drop support of Node.js snake_case flags
• Use a Symbol for attaching the gulplog namespace to the store
• Use a Symbol for attaching the gulplog store to the global
• Use sha256 to hash the v8flags cache into a filename

Features

• Streamlined the dependency tree
• Switch all streams implementation to Streamx
• Rewrote glob-stream to use a custom directory walk that relies on newer Node.js features and is more performant than old implementation
• Implement translation support for all CLI messages and all messages passing through gulplog
• Allow users to customize or remove the timestamp from their logs
• Upgraded gulplog to v2. Messages logged via v1 will also display a deprecated warning. Plugins should update to v2 as the community upgrades to gulp 5
• Added support for gulpile.cjs and gulpfile.mjs
• Add support for swc, esbuild, sucrase, and mdx loaders
• Provide an ESM export (#2760) (b00de68)
• Support sourcemap handling on streaming Vinyl contents
• Support extends syntax for .gulp.* config file
• Allow overriding gulpfile and preloads via .gulp.* config file

Bug Fixes

• Resolve bugs related to symlinks on various platforms
• Resolved some reported ReDoS CVEs and improved performance in glob-parent
• Rework errors surfaced when encountering files or symlinks when trying to create directories
• Ensure watch allows japanese characters in globs (72668c6)

... (truncated)

Changelog

Sourced from gulp's changelog.

5.0.0 (2024-03-29)

We've tried to provide a high-level changelog for gulp v5 below, but it doesn't contain all changes from the 60+ dependencies that we maintain.

Please see individual changelogs to drill down into all changes that were made.

⚠ BREAKING CHANGES

• Drop support for Node.js <10.13
• Default stream encoding to UTF-8
• Standardized on anymatch library for globbing paths. All globs should work the same between src and watch now!
• Removed support for ordered globs. This aligns with the chokidar globbing implementation. If you need your globs to be ordered, you can use ordered-read-stream
• All globs and paths are normalized to unix-like filepaths
• Only allow JS variants for .gulp.* config files
• Removed support for alpha releases of v4 from gulp-cli
• Removed the --verify flag
• Renamed the --require flag to --preload to avoid conflicting with Node.js flags
• Removed many legacy and deprecated loaders
• Upgrade to chokidar v3
• Clone Vinyl objects with stream contents using teex, but no longer wait for all streams to flow before cloned streams will receive data
• Stop using process.umask() to make directories, instead falling back to Node's default mode
• Throw on non-function, non-string option coercers
• Drop support of Node.js snake_case flags
• Use a Symbol for attaching the gulplog namespace to the store
• Use a Symbol for attaching the gulplog store to the global
• Use sha256 to hash the v8flags cache into a filename

Features

• Streamlined the dependency tree
• Switch all streams implementation to Streamx
• Rewrote glob-stream to use a custom directory walk that relies on newer Node.js features and is more performant than old implementation
• Implement translation support for all CLI messages and all messages passing through gulplog
• Allow users to customize or remove the timestamp from their logs
• Upgraded gulplog to v2. Messages logged via v1 will also display a deprecated warning. Plugins should update to v2 as the community upgrades to gulp 5
• Added support for gulpile.cjs and gulpfile.mjs
• Add support for swc, esbuild, sucrase, and mdx loaders
• Provide an ESM export (#2760) (b00de68)
• Support sourcemap handling on streaming Vinyl contents
• Support extends syntax for .gulp.* config file
• Allow overriding gulpfile and preloads via .gulp.* config file

Bug Fixes

• Resolve bugs related to symlinks on various platforms
• Resolved some reported ReDoS CVEs and improved performance in glob-parent
• Rework errors surfaced when encountering files or symlinks when trying to create directories
• Ensure watch allows japanese characters in globs (72668c6)

... (truncated)

Commits

• 5c4c547 chore: Release 5.0.0 (#2762)
• bf72116 chore: Add index.mjs to files list
• b00de68 feat: Provide an ESM export (#2760)
• 72668c6 chore!: Normalize repository, dropping node <10.13 support (#2758)
• 85896d4 chore(docs): Update stream handbook link (#2711)
• 818bd73 Docs: Remove gulp-sourcemaps because it is built-in (#2592)
• 598f971 Docs: Fix broken link in recipe (#2571)
• 9877de0 Docs: Guide CustomRegistries to maintain properties on tasks (fixes #2561) (#...
• f91c388 Docs: Remove typo in custom registry docs (#2543)
• df25250 Docs: Fix typo in task docs (#2524)
• Additional commits viewable in compare view

You can trigger a rebase of this PR by commenting @dependabot rebase.

---

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  You can disable automated security fix PRs for this repo from the Security Alerts page.

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

[TrevCraw]

@dependabot rebase

[TrevCraw]

@dependabot rebase

[TrevCraw]

@dependabot rebase

[dependabot]

Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting @dependabot rebase.

[TrevCraw]

@dependabot rebase

[JoshwinThomasIBM]

Tried running the tests in local with "gulp": "^5.0.0", and found that the project is not getting detected in the liberty dashboard and as a result the dev mode actions are failing , the click events fail since there is no element in the dashboard for them to interact with , please see the screenshot captured while running the tests

i tried the refresh button in the dashboard from the Vs code extension window, just to check if that can make the project get detected in the dashboard and see the tests are successful , but got the below error prompt

i also tried running the extension in local with gulp - 5.0.0 and after opening a gradle project into the IDE found the follwin g error

stack trace: Error: Client is not running and can't be stopped. It's current state is: startFailed
at LanguageClient.shutdown (/Users/joshwinthomas/IBM_workspace/VS Code/Issue382SecurutyVulFix/liberty-tools-vscode/dist/extension.js:21619:19)
at LanguageClient.stop (/Users/joshwinthomas/IBM_workspace/VS Code/Issue382SecurutyVulFix/liberty-tools-vscode/dist/extension.js:21590:21)
at LanguageClient.stop (/Users/joshwinthomas/IBM_workspace/VS Code/Issue382SecurutyVulFix/liberty-tools-vscode/dist/extension.js:20218:22)
at LanguageClient.doInitialize (/Users/joshwinthomas/IBM_workspace/VS Code/Issue382SecurutyVulFix/liberty-tools-vscode/dist/extension.js:21572:27)
at async LanguageClient.start (/Users/joshwinthomas/IBM_workspace/VS Code/Issue382SecurutyVulFix/liberty-tools-vscode/dist/extension.js:21427:13)
extensionHostProcess.js:162
rejected promise not handled within 1 second: Error: Client is not running and can't be stopped. It's current state is: startFailed
extensionHostProcess.js:162
stack trace: Error: Client is not running and can't be stopped. It's current state is: startFailed
at LanguageClient.shutdown (/Users/joshwinthomas/IBM_workspace/VS Code/Issue382SecurutyVulFix/liberty-tools-vscode/dist/extension.js:21619:19)
at LanguageClient.stop (/Users/joshwinthomas/IBM_workspace/VS Code/Issue382SecurutyVulFix/liberty-tools-vscode/dist/extension.js:21590:21)
at LanguageClient.stop (/Users/joshwinthomas/IBM_workspace/VS Code/Issue382SecurutyVulFix/liberty-tools-vscode/dist/extension.js:20218:22)
at LanguageClient.doInitialize (/Users/joshwinthomas/IBM_workspace/VS Code/Issue382SecurutyVulFix/liberty-tools-vscode/dist/extension.js:21572:27)
at async LanguageClient.start (/Users/joshwinthomas/IBM_workspace/VS Code/Issue382SecurutyVulFix/liberty-tools-vscode/dist/extension.js:21427:13)
extensionHostProcess.js:162
rejected promise not handled within 1 second: Error: Client is not running and can't be stopped. It's current state is: startFailed
extensionHostProcess.js:162
stack trace: Error: Client is not running and can't be stopped. It's current state is: startFailed
at LanguageClient.shutdown (/Users/joshwinthomas/IBM_workspace/VS Code/Issue382SecurutyVulFix/liberty-tools-vscode/dist/extension.js:21619:19)
at LanguageClient.stop (/Users/joshwinthomas/IBM_workspace/VS Code/Issue382SecurutyVulFix/liberty-tools-vscode/dist/extension.js:21590:21)
at LanguageClient.stop (/Users/joshwinthomas/IBM_workspace/VS Code/Issue382SecurutyVulFix/liberty-tools-vscode/dist/extension.js:20218:22)
at LanguageClient.doInitialize (/Users/joshwinthomas/IBM_workspace/VS Code/Issue382SecurutyVulFix/liberty-tools-vscode/dist/extension.js:21572:27)
at async LanguageClient.start (/Users/joshwinthomas/IBM_workspace/VS Code/Issue382SecurutyVulFix/liberty-tools-vscode/dist/extension.js:21427:13)
extensionHostProcess.js:162
rejected promise not handled within 1 second: Error: Client is not running and can't be stopped. It's current state is: startFailed
extensionHostProcess.js:162
stack trace: Error: Client is not running and can't be stopped. It's current state is: startFailed
at LanguageClient.shutdown (/Users/joshwinthomas/IBM_workspace/VS Code/Issue382SecurutyVulFix/liberty-tools-vscode/dist/extension.js:21619:19)
at LanguageClient.stop (/Users/joshwinthomas/IBM_workspace/VS Code/Issue382SecurutyVulFix/liberty-tools-vscode/dist/extension.js:21590:21)
at LanguageClient.stop (/Users/joshwinthomas/IBM_workspace/VS Code/Issue382SecurutyVulFix/liberty-tools-vscode/dist/extension.js:20218:22)
at LanguageClient.doInitialize (/Users/joshwinthomas/IBM_workspace/VS Code/Issue382SecurutyVulFix/liberty-tools-vscode/dist/extension.js:21572:27)
at async LanguageClient.start (/Users/joshwinthomas/IBM_workspace/VS Code/Issue382SecurutyVulFix/liberty-tools-vscode/dist/extension.js:21427:13)
extensionHostProcess.js:162

seems like the startLangServer is failing

[TrevCraw]

Thanks for investigating @JoshwinThomasIBM.

seems like the startLangServer is failing

If that is the case, check to see if the LS jars have been retrieved correctly and are placed in the jars folder. If not, there is a good chance that the gulp dependency update is causing the gulpfile build process to fail.

Please continue to investigate.

[gilbysunil14]

The project is not getting detected in the liberty dashboard since the liberty language server and jakarta language server is not getting started. Below are my observations regarding this:

1. What the command npm run build does is that it downloads the language server jars from the repository using gulp.

Below is the screenshot of the language server jars that is being downloaded while we execute the npm run build command after making the gulp version 5.0.0

Below is the screenshot of the language server jars that is being downloaded while we execute the npm run build command after making the gulp version 4.0.2

See that there is difference in the language server jars that are being downloaded(check the file size).

When I tried to download these jars manually by copying and pasting the download url from which these jars are getting downloaded using a browser, then the jar size is same as when we use the gulp version 4.0.2.

2. As per the documentation of gulp, there is a major change in the version 5.0.0 regarding defining tasks in gulp. In 4.0.2, the gulp tasks are defined using gulp.task. But in 5.0.0, the gulp tasks are defined using the exports. Hence, I have also tried changing the definition of tasks as below. But the issue is not getting resolved.

function downloadLibertyLSJars() {
  // Return a promise to signal async completion
  return Promise.all([
    download({
      url: libertyLemminxURL,
      file: libertyLemminxName,
    })
    .pipe(gulp.dest("./jars")),  // Pipe the download result to the 'jars' folder

    download({
      url: libertyLSURL,
      file: libertyLSName,
    })
    .pipe(gulp.dest("./jars"))  // Pipe the download result to the 'jars' folder
  ]);
}

exports.downloadLibertyLSJars = downloadLibertyLSJars;

function downloadLSP4JakartaJars() {
  // Return a Promise to signal async completion
  return Promise.all([
    download({
      url: jakartaJDTURL,
      file: jakartaJdtName,
    })
    .pipe(gulp.dest("./jars")),  // Pipe the download result to the 'jars' folder

    download({
      url: jakartaLSURL,
      file: jakartaLSName,
    })
    .pipe(gulp.dest("./jars"))  // Pipe the download result to the 'jars' folder
  ]);
}

exports.downloadLSP4JakartaJars = downloadLSP4JakartaJars;

[gilbysunil14]

Fixes #418