Tests implementation liberty-ls support in server.xml for diagnostic and quickfix #377
+156
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/test/utils/testUtils.ts
Outdated
| */ | ||
| export async function removeConfigDir(projectPath: string): Promise<void> { | ||
| try { | ||
| await fs.accessSync(projectPath); |
There was a problem hiding this comment.
The following methods are synchronous methods. await has no effect on them.
accessSync, readdirSync, lstatSync, unlinkSync, rmdirSync
src/test/GradleSingleModLCLSTest.ts
Outdated
| utils.copyConfig(path.join(utils.getGradleProjectPath(), 'src', 'main', 'liberty', 'config'), path.join(utils.getGradleProjectPath(), 'src', 'main', 'liberty', 'config2')); | ||
| }); | ||
|
|
||
| it('Should coppy content of server.xml', async () => { |
src/test/GradleSingleModLCLSTest.ts
Outdated
| editor = await new EditorView().openEditor('server.xml') as TextEditor; | ||
| actualSeverXMLContent = await editor.getText(); | ||
|
|
||
| assert(actualSeverXMLContent.length !== 0, 'Content of server.xml is not in coppied.'); |
There was a problem hiding this comment.
typo copied. check for similar typos
| const qckFixPopupLink = await hoverTxt.findElement(By.xpath("//*[contains(text(), 'Quick Fix')]")); | ||
| await qckFixPopupLink.click(); | ||
|
|
||
| const hoverTaskBar = await editor.findElement(By.className('context-view monaco-component bottom left fixed')); |
There was a problem hiding this comment.
Is hoverTaskBar required? There is no actionable task performed by hoverTaskBar. It seems that removing below two lines does not affect the test. Kindly confirm.
gilbysunil14
requested changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #370 Fixes #434