Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NPE in OpenAPI validation #30528

Open
wants to merge 2 commits into
base: integration
Choose a base branch
from
Open

Fix NPE in OpenAPI validation #30528

wants to merge 2 commits into from

Conversation

Azquelt
Copy link
Member

@Azquelt Azquelt commented Jan 10, 2025

Fixes #30303

@Azquelt
Remove AllowFFDC for OpenAPI TCKs
403d4d5 
These TCKs don't actually provoke FFDCs, the annotation was likely
copied from a TCK for a different spec.
@Azquelt
Copy link
Member Author

Azquelt commented Jan 10, 2025 •
edited by LibbyBot
Loading

#build
(view Open Liberty Personal Build - ❌ completed with errors/failures.)
#spawn.fullfat.buckets=com.ibm.ws.microprofile.openapi.1.1_fat_tck,com.ibm.ws.microprofile.openapi_fat,com.ibm.ws.microprofile.openapi_fat_tck,com.ibm.ws.openapi.ui_fat,io.openliberty.microprofile.openapi.2.0.internal_fat,io.openliberty.microprofile.openapi.2.0.internal_fat_tck,io.openliberty.microprofile.openapi.3.0.internal_fat_tck,io.openliberty.microprofile.openapi.3.1.internal_fat_tck,io.openliberty.microprofile.openapi.4.0.internal_fat,io.openliberty.microprofile.openapi.4.0.internal_fat_tck,io.openliberty.microprofile.openapi.ui.internal_fat

Note: Target locations of links might be accessible only to IBM employees.

@Azquelt
Fix NPE in OpenAPI validation
6ccfaa4 
NPE could occur if a path item had been manually added as a child of a
schema. This unusual situation is tested by the TCK.
@Azquelt Azquelt force-pushed the openapi-validation-npe branch from 1380b2b to 6ccfaa4 Compare January 10, 2025 13:36
@Azquelt
Copy link
Member Author

Azquelt commented Jan 10, 2025 •
edited by LibbyBot
Loading

#build
(view Open Liberty Personal Build - ✅ completed successfully!)
#spawn.fullfat.buckets=com.ibm.ws.microprofile.openapi.1.1_fat_tck,com.ibm.ws.microprofile.openapi_fat,com.ibm.ws.microprofile.openapi_fat_tck,com.ibm.ws.openapi.ui_fat,io.openliberty.microprofile.openapi.2.0.internal_fat,io.openliberty.microprofile.openapi.2.0.internal_fat_tck,io.openliberty.microprofile.openapi.3.0.internal_fat_tck,io.openliberty.microprofile.openapi.3.1.internal_fat_tck,io.openliberty.microprofile.openapi.4.0.internal_fat,io.openliberty.microprofile.openapi.4.0.internal_fat_tck,io.openliberty.microprofile.openapi.ui.internal_fat

Note: Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.

  • 4 FAT files were changed, added, or removed.

  • Check that the build did not break the affected FAT suite(s).

  • 1 product code files were changed.

  • Please describe in a separate comment how you tested your changes.

abutch3r
abutch3r approved these changes Jan 10, 2025
View reviewed changes
Copy link
Member

@abutch3r abutch3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abutch3r abutch3r abutch3r approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MP OpenAPI 4.0 NPE during validation
3 participants
@Azquelt @LibbyBot @abutch3r