Issue233 #550
Draft
Issue233 #550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…at to match with user specification
… print statements from debugging
… parameter variable lists from the phase object rather than hardcoded lists
|
Will you make a more meaningful title? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes the initial guessing in phase info consistent for the user and requires initial guesses for all phases to be specified as [initial, final] pairs.
The initial guessing functions are also tidied up to try and reduce the number of separate logic blocks in the code.
At some point in the future it would be nice to get the lists of control and state variables from within the phase definitions, rather than having hardcoded lists that are dependent on phase_name and mission_method.
The initial guesses for the integration variable (usually time, sometimes mass) is now specified by checking the dymos phase for the 'name' of 'time', which is a more robust implementation, however the need for checking phase_name and mission_method has not been totally eliminated.
Related Issues
Backwards incompatibilities
All phase info dictionaries with initial guesses will need to be updated to conform with the [initial, final] specification.
New Dependencies
None