Test FLOPS Aero Builder #619
Conversation
…tion is generated.
| @@ -39,7 +37,7 @@ | |||
| GASP = LegacyCode.GASP | |||
| FLOPS = LegacyCode.FLOPS | |||
|
|
|||
| _default_name = 'aerodynamics' | |||
| default_name = 'aerodynamics' | |||
There was a problem hiding this comment.
I'd prefer to keep the old name - it marks default_name as a variable intended as private to this file, so other devs know they shouldn't try from aerodynamics_builder import default_name
It's unlikely anyone would ever even want that, but it's good practice
There was a problem hiding this comment.
It is required by unittest because TestSubsystemBuilderBase has an attribute default_name.
| @@ -387,7 +385,7 @@ def get_parameters(self, aviary_inputs=None, phase_info=None): | |||
|
|
|||
| val = meta['default_value'] | |||
| if val is None: | |||
| val = _unspecified | |||
| val = 0.0 # _unspecified | |||
There was a problem hiding this comment.
_unspecified might actually be useful here? If used consistently throughout the code it could provide a valid use of None as a default, although I'm unsure where that would be helpful.
There was a problem hiding this comment.
The unittest does not like it.
| self.assertIn( | ||
| 'val', val, "The dictionaries returned by get_parameters() should have a 'val' key") | ||
| 'val', val, f"The dictionaries returned by get_parameters() should have a 'val' key for {key}") |
There was a problem hiding this comment.
wording
---> should have a 'val' for key '{key}'."
Summary
Added a unit test file for FLOPS based aerodynamic builder (20 unit tests).
Note: the unit test file for GASP based aerodynamic builder has to be put on hold because it depends on the consistency of default values in several GASP based components.
Related Issues
Backwards incompatibilities
None
New Dependencies
None