Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve duplicate N2 report generation #632

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Resolve duplicate N2 report generation #632

wants to merge 8 commits into from

Conversation

jkirk5
Copy link
Contributor

@jkirk5 jkirk5 commented Dec 13, 2024 •
edited
Loading

Summary

Rework L1 interface to always route n2 generation to openmdao report directory. This means the outdir argument for run_mission is now removed, as it only affected where this post-mission generated n2 goes

Related Issues

Backwards incompatibilities

None

New Dependencies

None

Kenneth-T-Moore
Kenneth-T-Moore approved these changes Dec 22, 2024
View reviewed changes
Copy link
Member

@Kenneth-T-Moore Kenneth-T-Moore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but you can remove the commented-out argument.

@jkirk5 jkirk5 requested a review from hschilling January 13, 2025 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kenneth-T-Moore Kenneth-T-Moore Kenneth-T-Moore approved these changes

@hschilling hschilling Awaiting requested review from hschilling

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Double creation of n2.html file
2 participants
@jkirk5 @Kenneth-T-Moore