Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set FLOPS mass default #635

Open
wants to merge 23 commits into
base: main
Choose a base branch
from
Open

Set FLOPS mass default #635

wants to merge 23 commits into from

Conversation

xjjiang
Copy link
Contributor

@xjjiang xjjiang commented Dec 23, 2024 •
edited
Loading

Summary

This PR serves as an experiment to standardize component defaults across Aviary. FLOPS mass is chosen because it is the clearest subsystems in Aviary. In this PR,

  • Functions add_aviary_input/add_aviary_output set value to 0.0 if there is no metadata default value.
  • Default values are set to 0.0 in variable_meta_data.py for variables used by FLOPS mass subsystems.
  • In all components of FLOPS mass subsystem, val argument is removed from add_aviary_input/add_aviary_output calls.
    • Example: add_aviary_input(self, Aircraft.Avionics.MASS)

Related Issues

  • Resolves #

Backwards incompatibilities

None

New Dependencies

None

@xjjiang xjjiang marked this pull request as draft December 23, 2024 16:51
@xjjiang xjjiang marked this pull request as ready for review December 23, 2024 20:57
jkirk5
jkirk5 approved these changes Dec 30, 2024
View reviewed changes
Copy link
Contributor

@jkirk5 jkirk5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jkirk5 jkirk5 enabled auto-merge January 8, 2025 18:09
auto-merge was automatically disabled January 9, 2025 22:12

Head branch was pushed to by a user without write access

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkirk5 jkirk5 jkirk5 approved these changes

@Kenneth-T-Moore Kenneth-T-Moore Kenneth-T-Moore approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xjjiang @Kenneth-T-Moore @jkirk5