Set geom default #638

xjjiang · 2024-12-30T22:33:33Z

Summary

In this PR,

Functions add_aviary_input/add_aviary_output set value to 0.0 if there is no metadata default value.
Default values are set to 0.0 in variable_meta_data.py for variables used by geometry subsystems.
In all components of geometry subsystem, val argument is removed from add_aviary_input/add_aviary_output calls.
- Example: add_aviary_input(self, Aircraft.Canard.AREA)
Exceptions for now:
- Aircraft.Fuselage.AVG_DIAMETER is still default to inch.
- In Group classes, set_input_defaults() still take non-default values.

Related Issues

Resolves #

Backwards incompatibilities

None

New Dependencies

None

…raft.Canard.WETTED_AREA_SCALER to default in metadata. output Aircraft.Canard.WETTED_AREA to default in metadata.

…ft.Canard.THICKNESS_TO_CHORD, Aircraft.Fuselage.AVG_DIAMETER, Aircraft.Fuselage.LENGTH, Aircraft.HorizontalTail.AREA, Aircraft.HorizontalTail.THICKNESS_TO_CHORD, Aircraft.VerticalTail.AREA, Aircraft.VerticalTail.ASPECT_RATIO, Aircraft.VerticalTail.THICKNESS_TO_CHORD, Aircraft.Wing.AREA, Aircraft.Wing.ASPECT_RATIO, Aircraft.Wing.GLOVE_AND_BAT, Aircraft.Wing.TAPER_RATIO, Aircraft.Wing.THICKNESS_TO_CHORD, Aircraft.Canard.CHARACTERISTIC_LENGTH, Aircraft.Canard.FINENESS, Aircraft.Fuselage.CHARACTERISTIC_LENGTH, Aircraft.Fuselage.FINENESS, Aircraft.HorizontalTail.CHARACTERISTIC_LENGTH, Aircraft.HorizontalTail.FINENESS to metadata values (0.0). Set inputs Aircraft.Nacelle.AVG_DIAMETER, Aircraft.Nacelle.AVG_LENGTH to metadata values ([0.0]) with shape (num_engine_type). Set input Aircraft.HorizontalTail.ASPECT_RATIO to to metadata values (4.75) for now. Set outputs Aircraft.VerticalTail.CHARACTERISTIC_LENGTH, Aircraft.Nacelle.FINENESS to metadata values ([0.0]) with shape (num_engine_type). Set outputs Aircraft.VerticalTail.CHARACTERISTIC_LENGTH, Aircraft.Wing.CHARACTERISTIC_LENGTH, Aircraft.Wing.FINENESS to metadata values (0.0).

…rcraft.Fuselage.MAX_WIDTH to metadata value (0.0). Set outputs Aircraft.Fuselage.AVG_DIAMETER, Aircraft.Fuselage.PLANFORM_AREA to metadata value (0.0).

…, Aircraft.Nacelle.WETTED_AREA_SCALER to metadata values ([0.0]) with shape (num_engine_type). Set Aircraft.Nacelle.TOTAL_WETTED_AREA to metadata values (0.0). Set Aircraft.Nacelle.WETTED_AREA to metadata values ([0.0]) with shape (num_engine_type).

…H, Aircraft.HorizontalTail.AREA, Aircraft.HorizontalTail.ASPECT_RATIO, Aircraft.HorizontalTail.THICKNESS_TO_CHORD, Aircraft.VerticalTail.AREA, Aircraft.VerticalTail.ASPECT_RATIO, Aircraft.VerticalTail.THICKNESS_TO_CHORD, Aircraft.Wing.AREA, Aircraft.Wing.GLOVE_AND_BAT, Aircraft.Wing.SPAN, Aircraft.Wing.TAPER_RATIO, Aircraft.Wing.THICKNESS_TO_CHORD to metadata values (0.0). Keep input Aircraft.HorizontalTail.TAPER_RATIO to 0.352 for now because in gasp based empennage, 'tr' is set to 0.352.

…, Aircraft.HorizontalTail.WETTED_AREA, Aircraft.Nacelle.TOTAL_WETTED_AREA, Aircraft.VerticalTail.WETTED_AREA, Aircraft.Wing.WETTED_AREA to metadata values (0.0). Set output Aircraft.Design.TOTAL_WETTED_AREA to to metadata values (0.0).

…Wing.SPAN to metadata values (0.0). Set output Aircraft.Wing.ASPECT_RATIO to metadata values (0.0).

…s [0.35]) with shape total_num_wing_engines/2. Set input Aircraft.Wing.SPAN to metadata values (0.0) (was 128). Set input Fuselage.AVG_DIAMETER to metadata values (0.0) (was 10). Set output Aircraft.Electrical.HYBRID_CABLE_LENGTH to metadata values (0.0).

…values (0.0). Set Aircraft.Fuselage.LENGTH to metadata values (0.0) (was 129.4). Set Aircraft.Wing.AREA to metadata values (0.0) (was 1370).

…]) (was 5.8) with shape (num_engine_type). Set input Aircraft.Engine.SCALE_FACTOR to metadata values ([0.0]) with shape (num_engine_type). Set input Aircraft.Nacelle.CORE_DIAMETER_RATIO to metadata values ([0.0]) (was 1.25) with shape (num_engine_type). Set input Aircraft.Nacelle.FINENESS to metadata values ([0.0]) (was 2) with shape (num_engine_type). Set ouputs Aircraft.Nacelle.AVG_DIAMETER, Aircraft.Nacelle.AVG_LENGTH, and Aircraft.Nacelle.SURFACE_AREA with shape (num_engine_type).

…was 4.5). Set input Aircraft.Fuselage.PILOT_COMPARTMENT_LENGTH to metadata values (0.0) (was 9.5). Set output Aircraft.Fuselage.AVG_DIAMETER to default 0.0 with units='inch' for now.

…TTACHMENT_LOCATION_DIMENSIONLESS to metadata values (0.0). Set input Aircraft.Wing.FOLDED_SPAN to metadata values (0.0) (was 25). Set input add_aviary_input(self, Aircraft.Wing.FOLDED_SPAN_DIMENSIONLESS to metadata values (0.0).

…input Aircraft.Strut.AREA_RATIO to metadata values (0.0) (was .2). Set input to metadata values (0.0). Set input Aircraft.Fuselage.AVG_DIAMETER to metadata values (0.0) (was 10.0). Set outputs Aircraft.Strut.LENGTH, Aircraft.Strut.AREA, and Aircraft.Strut.CHORD to metadata values (0.0).

…000). Set input Aircraft.Wing.LOADING to metadata values (0.0) (was 128). Set input Aircraft.Wing.ASPECT_RATIO to metadata values (0.0) (was 10.13). Set input Aircraft.Wing.AREA to metadata values (0.0) (was 2). Set input Aircraft.Wing.SPAN to metadata values (0.0) (was 2). Set input Aircraft.Wing.TAPER_RATIO to metadata values (0.0) (was 0.33). Set input Aircraft.Wing.SWEEP to metadata values (0.0) (was 25). Set input Aircraft.Wing.THICKNESS_TO_CHORD_ROOT to metadata values (0.0) (was 0.11). Set input Aircraft.Fuselage.AVG_DIAMETER to metadata values (0.0) (was 10). Set input Aircraft.Wing.THICKNESS_TO_CHORD_TIP to metadata values (0.0) (was 0.1). Set input Aircraft.Fuel.WING_FUEL_FRACTION to metadata values (0.0) (was 0.6). Set input Aircraft.Fuel.WING_VOLUME_GEOMETRIC_MAX to metadata values (0.0). Set input Aircraft.Wing.FOLDED_SPAN to metadata values (0.0) (was 25). Set input Aircraft.Wing.AREA to metadata values (0.0) (was 200). Set input Aircraft.Wing.SPAN to metadata values (0.0) (was 118). Set outputs to metadata values (0.0).

…_aviary_output(self, Aircraft.Fuel.AUXILIARY_FUEL_CAPACITY)

…r = 0 in empennage.py

aviary/variable_info/variable_meta_data.py

…Wing.AREA from 1370 to 0.0.

…hanged Aircraft.Fuselage.TAIL_FINENESS from 3 to default(1).

…LENGTH, val=9.5) for testing

…nput_defaults(Aircraft.VerticalTail.TAPER_RATIO, 0.0)

…set_geom_default

xjjiang added 17 commits December 30, 2024 09:12

inputs Aircraft.Canard.AREA, Aircraft.Canard.THICKNESS_TO_CHORD, Airc…

18d9819

…raft.Canard.WETTED_AREA_SCALER to default in metadata. output Aircraft.Canard.WETTED_AREA to default in metadata.

set inputs Aircraft.Fuselage.LENGTH, Aircraft.Fuselage.MAX_HEIGHT, Ai…

d87ca64

…rcraft.Fuselage.MAX_WIDTH to metadata value (0.0). Set outputs Aircraft.Fuselage.AVG_DIAMETER, Aircraft.Fuselage.PLANFORM_AREA to metadata value (0.0).

set inputs Aircraft.Wing.AREA, Aircraft.Wing.GLOVE_AND_BAT, Aircraft.…

5041a58

…Wing.SPAN to metadata values (0.0). Set output Aircraft.Wing.ASPECT_RATIO to metadata values (0.0).

set input Aircraft.HorizontalTail.VERTICAL_TAIL_FRACTION to metadata …

6dab166

…values (0.0). Set Aircraft.Fuselage.LENGTH to metadata values (0.0) (was 129.4). Set Aircraft.Wing.AREA to metadata values (0.0) (was 1370).

set input Aircraft.Fuselage.DELTA_DIAMETER to metadata values (0.0) (…

4cf0b21

…was 4.5). Set input Aircraft.Fuselage.PILOT_COMPARTMENT_LENGTH to metadata values (0.0) (was 9.5). Set output Aircraft.Fuselage.AVG_DIAMETER to default 0.0 with units='inch' for now.

update unit tests

34bbcd8

set values when val is None in add_aviary_input/add_aviary_output.

414bb7a

set default_values for geometry subsystem.

f8f9b46

xjjiang marked this pull request as draft December 30, 2024 22:33

xjjiang added 12 commits December 30, 2024 14:46

autopep8

25268f0

autopep8

9e79199

minor updates

faaa1ba

Replace self.add_output(Aircraft.Fuel.AUXILIARY_FUEL_CAPACITY) by add…

eac7d8a

…_aviary_output(self, Aircraft.Fuel.AUXILIARY_FUEL_CAPACITY)

autopep8

0b36676

autopep8

2fda6d7

set Aircraft.HorizontalTail.TAPER_RATIO = 0 in prep_geom.py and set t…

f44f6c3

…r = 0 in empennage.py

autopep8

638318c

update a comment.

37f8463

set Aircraft.HorizontalTail.TAPER_RATIO = 0.352 in unit test.

38fd95e

roll back Aircraft.HorizontalTail.TAPER_RATIO = 0.352 for now.

f5955fc

roll back tr = 0.352 in empennage.py

65e8149

Kenneth-T-Moore reviewed Jan 2, 2025

View reviewed changes

aviary/variable_info/variable_meta_data.py Outdated Show resolved Hide resolved

Kenneth-T-Moore reviewed Jan 2, 2025

View reviewed changes

aviary/variable_info/variable_meta_data.py Outdated Show resolved Hide resolved

Kenneth-T-Moore reviewed Jan 2, 2025

View reviewed changes

aviary/variable_info/variable_meta_data.py Show resolved Hide resolved

xjjiang and others added 23 commits January 2, 2025 11:23

set more variables to defaults in prep_geom.py

4534b1f

Changed Aircraft.Fuselage.LENGTH from 129.4 to 0.0. Changed Aircraft.…

944930e

…Wing.AREA from 1370 to 0.0.

Changed Aircraft.Fuselage.PILOT_COMPARTMENT_LENGTH from 9.5 to 0.0. C…

15fd751

…hanged Aircraft.Fuselage.TAIL_FINENESS from 3 to default(1).

added a couple of default_value=0.0

2502fec

commented out set_input_defaults(Aircraft.Fuselage.PILOT_COMPARTMENT_…

1edb4ec

…LENGTH, val=9.5) for testing

commented out four set_input_defaults() lines for testing.

ace57d2

moved set_input_defaults to unit test (WingGroupTestCase4).

fd4fa9f

commented out set_input_defaults() lines in EmpennageSize.

a67e11c

autopep8

82496ef

set_input_defaults(Aircraft.VerticalTail.ASPECT_RATIO, 0.0) and set_i…

61bacad

…nput_defaults(Aircraft.VerticalTail.TAPER_RATIO, 0.0)

autopep8

43b6a4c

minor updates

f4c2e6b

Merge branch 'main' into set_geom_default

386a885

Merge branch 'set_geom_default' of github.com:xjjiang/om-Aviary into …

d3a5d4d

…set_geom_default

Merge branch 'OpenMDAO:main' into set_geom_default

f729d2b

Merge branch 'set_geom_default' of github.com:xjjiang/om-Aviary into …

95f8901

…set_geom_default

minor update

89c3424

remove temperary comments.

f613fdf

remove two comments

97f19bb

remove val= from individual components

159b81c

set val in two places

3b083fb

set a few default values to 0.0.

f871e3a

set Aircraft.HorizontalTail.TAPER_RATIO = 0.0

ccef2a8

xjjiang marked this pull request as ready for review January 13, 2025 17:44

jkirk5 self-requested a review January 13, 2025 19:04

Kenneth-T-Moore approved these changes Jan 13, 2025

View reviewed changes

Merge branch 'OpenMDAO:main' into set_geom_default

2b55cfd

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Set geom default #638

Set geom default #638

xjjiang commented Dec 30, 2024 •

edited

Loading

Set geom default #638

Are you sure you want to change the base?

Set geom default #638

Conversation

xjjiang commented Dec 30, 2024 • edited Loading

Summary

Related Issues

Backwards incompatibilities

New Dependencies

xjjiang commented Dec 30, 2024 •

edited

Loading