reworking tests - wip

OpenPonk · Jun 30, 2024 · 945365c · 945365c
1 parent 577445e
commit 945365c
Show file tree

Hide file tree

Showing 18 changed files with 98 additions and 229 deletions.
diff --git a/repository/OpenPonk-BPMN/OPBPMNActivityController.class.st b/repository/OpenPonk-BPMN/OPBPMNActivityController.class.st
@@ -61,11 +61,6 @@ OPBPMNActivityController >> canBeTargetFor: aController [
 			 ]
 ]
 
-{ #category : 'accessing' }
-OPBPMNActivityController >> dependentElements [
-	^ (model incoming , model outgoing) asSet
-]
-
 { #category : 'connecting' }
 OPBPMNActivityController >> diagramElementClass [
 

diff --git a/repository/OpenPonk-BPMN/OPBPMNActivityControllerTest.class.st b/repository/OpenPonk-BPMN/OPBPMNActivityControllerTest.class.st
@@ -12,21 +12,21 @@ OPBPMNActivityControllerTest >> controllerClass [
 ]
 
 { #category : 'accessing' }
-OPBPMNActivityControllerTest >> diagramElementClass [
-	^ OPBPMNActivityShape
+OPBPMNActivityControllerTest >> creationTargetControllerClass [
+	^ OPBPMNPoolController  
 ]
 
 { #category : 'accessing' }
-OPBPMNActivityControllerTest >> modelClass [
-	^ OPBPMNActivityModel 
+OPBPMNActivityControllerTest >> creationTargetModelClass [
+	^ OPBPMNPoolModel 
 ]
 
 { #category : 'accessing' }
-OPBPMNActivityControllerTest >> targetControllerClass [
-	^ OPBPMNPoolController  
+OPBPMNActivityControllerTest >> diagramElementClass [
+	^ OPBPMNActivityShape
 ]
 
 { #category : 'accessing' }
-OPBPMNActivityControllerTest >> targetModelClass [
-	^ OPBPMNPoolModel 
+OPBPMNActivityControllerTest >> modelClass [
+	^ OPBPMNActivityModel 
 ]
diff --git a/repository/OpenPonk-BPMN/OPBPMNBasicFlowControllerTest.class.st b/repository/OpenPonk-BPMN/OPBPMNBasicFlowControllerTest.class.st
@@ -23,11 +23,12 @@ OPBPMNBasicFlowControllerTest >> modelClass [
 ]
 
 { #category : 'accessing' }
-OPBPMNBasicFlowControllerTest >> targetControllerClass [
-	^ OPBPMNActivityController  
+OPBPMNBasicFlowControllerTest >> sourceControllerClass [
+
+	^ OPBPMNActivityController
 ]
 
 { #category : 'accessing' }
-OPBPMNBasicFlowControllerTest >> targetModelClass [
+OPBPMNBasicFlowControllerTest >> sourceModelClass [
 	^ OPBPMNActivityModel 
 ]
diff --git a/repository/OpenPonk-BPMN/OPBPMNBoundaryEventTest.class.st b/repository/OpenPonk-BPMN/OPBPMNBoundaryEventTest.class.st
@@ -12,23 +12,23 @@ OPBPMNBoundaryEventTest >> controllerClass [
 ]
 
 { #category : 'accessing' }
-OPBPMNBoundaryEventTest >> diagramElementClass [
-	^ OPBPMNBoundaryEventShape 
+OPBPMNBoundaryEventTest >> creationTargetControllerClass [
+	^ OPBPMNSubProcessController 
 ]
 
 { #category : 'accessing' }
-OPBPMNBoundaryEventTest >> modelClass [
-	^ OPBPMNBoundaryEventModel 
+OPBPMNBoundaryEventTest >> creationTargetModelClass [
+	^ OPBPMNSubProcessModel  
 ]
 
 { #category : 'accessing' }
-OPBPMNBoundaryEventTest >> targetControllerClass [
-	^ OPBPMNSubProcessController 
+OPBPMNBoundaryEventTest >> diagramElementClass [
+	^ OPBPMNBoundaryEventShape 
 ]
 
 { #category : 'accessing' }
-OPBPMNBoundaryEventTest >> targetModelClass [
-	^ OPBPMNSubProcessModel  
+OPBPMNBoundaryEventTest >> modelClass [
+	^ OPBPMNBoundaryEventModel 
 ]
 
 { #category : 'accessing' }

diff --git a/repository/OpenPonk-BPMN/OPBPMNCollapsedSubProcessController.class.st b/repository/OpenPonk-BPMN/OPBPMNCollapsedSubProcessController.class.st
@@ -69,11 +69,6 @@ OPBPMNCollapsedSubProcessController >> canBeTargetFor: aController [
 			 ]
 ]
 
-{ #category : 'testing' }
-OPBPMNCollapsedSubProcessController >> dependentElements [
-	^ (model incoming , model outgoing) asSet
-]
-
 { #category : 'testing' }
 OPBPMNCollapsedSubProcessController >> diagramElementClass [
 

diff --git a/repository/OpenPonk-BPMN/OPBPMNCollapsedSubProcessTest.class.st b/repository/OpenPonk-BPMN/OPBPMNCollapsedSubProcessTest.class.st
@@ -12,21 +12,21 @@ OPBPMNCollapsedSubProcessTest >> controllerClass [
 ]
 
 { #category : 'accessing' }
-OPBPMNCollapsedSubProcessTest >> diagramElementClass [
-	^ OPBPMNCollapsedSubProcessShape 
+OPBPMNCollapsedSubProcessTest >> creationTargetControllerClass [
+	^ OPBPMNPoolController  
 ]
 
 { #category : 'accessing' }
-OPBPMNCollapsedSubProcessTest >> modelClass [
-	^ OPBPMNCollapsedSubProcessModel 
+OPBPMNCollapsedSubProcessTest >> creationTargetModelClass [
+	^ OPBPMNPoolModel 
 ]
 
 { #category : 'accessing' }
-OPBPMNCollapsedSubProcessTest >> targetControllerClass [
-	^ OPBPMNPoolController  
+OPBPMNCollapsedSubProcessTest >> diagramElementClass [
+	^ OPBPMNCollapsedSubProcessShape 
 ]
 
 { #category : 'accessing' }
-OPBPMNCollapsedSubProcessTest >> targetModelClass [
-	^ OPBPMNPoolModel 
+OPBPMNCollapsedSubProcessTest >> modelClass [
+	^ OPBPMNCollapsedSubProcessModel 
 ]
diff --git a/repository/OpenPonk-BPMN/OPBPMNControllerTest.class.st b/repository/OpenPonk-BPMN/OPBPMNControllerTest.class.st
diff --git a/repository/OpenPonk-BPMN/OPBPMNDataFlowControllerTest.class.st b/repository/OpenPonk-BPMN/OPBPMNDataFlowControllerTest.class.st
@@ -23,12 +23,12 @@ OPBPMNDataFlowControllerTest >> modelClass [
 ]
 
 { #category : 'accessing' }
-OPBPMNDataFlowControllerTest >> targetControllerClass [
+OPBPMNDataFlowControllerTest >> sourceControllerClass [
 	^ OPBPMNDataObjectController  
 ]
 
 { #category : 'accessing' }
-OPBPMNDataFlowControllerTest >> targetModelClass [
+OPBPMNDataFlowControllerTest >> sourceModelClass [
 	^ OPBPMNDataObjectModel 
 ]
 

diff --git a/repository/OpenPonk-BPMN/OPBPMNDataObjectTest.class.st b/repository/OpenPonk-BPMN/OPBPMNDataObjectTest.class.st
@@ -12,21 +12,21 @@ OPBPMNDataObjectTest >> controllerClass [
 ]
 
 { #category : 'accessing' }
-OPBPMNDataObjectTest >> diagramElementClass [
-	^ OPBPMNDataObjectShape 
+OPBPMNDataObjectTest >> creationTargetControllerClass [
+	^ OPBPMNPoolController    
 ]
 
 { #category : 'accessing' }
-OPBPMNDataObjectTest >> modelClass [
-	^ OPBPMNDataObjectModel 
+OPBPMNDataObjectTest >> creationTargetModelClass [
+	^ OPBPMNPoolModel 
 ]
 
 { #category : 'accessing' }
-OPBPMNDataObjectTest >> targetControllerClass [
-	^ OPBPMNPoolController    
+OPBPMNDataObjectTest >> diagramElementClass [
+	^ OPBPMNDataObjectShape 
 ]
 
 { #category : 'accessing' }
-OPBPMNDataObjectTest >> targetModelClass [
-	^ OPBPMNPoolModel 
+OPBPMNDataObjectTest >> modelClass [
+	^ OPBPMNDataObjectModel 
 ]
diff --git a/repository/OpenPonk-BPMN/OPBPMNEndEventControllerTest.class.st b/repository/OpenPonk-BPMN/OPBPMNEndEventControllerTest.class.st
@@ -12,22 +12,22 @@ OPBPMNEndEventControllerTest >> controllerClass [
 ]
 
 { #category : 'accessing' }
-OPBPMNEndEventControllerTest >> diagramElementClass [
-
-	^ OPBPMNEndEventShape 
+OPBPMNEndEventControllerTest >> creationTargetControllerClass [
+	^ OPBPMNPoolController  
 ]
 
 { #category : 'accessing' }
-OPBPMNEndEventControllerTest >> modelClass [
-	^ OPBPMNEndEventModel 
+OPBPMNEndEventControllerTest >> creationTargetModelClass [
+	^ OPBPMNPoolModel
 ]
 
 { #category : 'accessing' }
-OPBPMNEndEventControllerTest >> targetControllerClass [
-	^ OPBPMNPoolController  
+OPBPMNEndEventControllerTest >> diagramElementClass [
+
+	^ OPBPMNEndEventShape 
 ]
 
 { #category : 'accessing' }
-OPBPMNEndEventControllerTest >> targetModelClass [
-	^ OPBPMNPoolModel
+OPBPMNEndEventControllerTest >> modelClass [
+	^ OPBPMNEndEventModel 
 ]
diff --git a/repository/OpenPonk-BPMN/OPBPMNFlowControllerTest.class.st b/repository/OpenPonk-BPMN/OPBPMNFlowControllerTest.class.st
@@ -1,10 +1,6 @@
 Class {
 	#name : 'OPBPMNFlowControllerTest',
-	#superclass : 'OPBPMNControllerTest',
-	#instVars : [
-		'fromCtrl',
-		'toCtrl'
-	],
+	#superclass : 'OPAbstractDirectionalRelationshipControllerTest',
 	#category : 'OpenPonk-BPMN-Tests',
 	#package : 'OpenPonk-BPMN',
 	#tag : 'Tests'
@@ -23,27 +19,22 @@ OPBPMNFlowControllerTest >> amountOfLabels [
 	^ 1
 ]
 
-{ #category : 'tests' }
-OPBPMNFlowControllerTest >> controllerClass [
-	^ self subclassResponsibility
-]
+{ #category : 'accessing' }
+OPBPMNFlowControllerTest >> diagramControllerClass [
 
-{ #category : 'tests' }
-OPBPMNFlowControllerTest >> diagramElementClass [
+	^ OPBPMNDiagramController
+]
 
-	^ self subclassResponsibility
+{ #category : 'accessing' }
+OPBPMNFlowControllerTest >> diagramModelClass [
+	^ OPBPMNModel 
 ]
 
 { #category : 'tests' }
 OPBPMNFlowControllerTest >> fromClass [
 	^ OPBPMNStartEventController 
 ]
 
-{ #category : 'tests' }
-OPBPMNFlowControllerTest >> modelClass [
-	^ self subclassResponsibility
-]
-
 { #category : 'tests' }
 OPBPMNFlowControllerTest >> setUp [
 

diff --git a/repository/OpenPonk-BPMN/OPBPMNGatewayControllerTest.class.st b/repository/OpenPonk-BPMN/OPBPMNGatewayControllerTest.class.st
@@ -12,21 +12,21 @@ OPBPMNGatewayControllerTest >> controllerClass [
 ]
 
 { #category : 'accessing' }
-OPBPMNGatewayControllerTest >> diagramElementClass [
-	^ OPBPMNGatewayShape
+OPBPMNGatewayControllerTest >> creationTargetControllerClass [
+	^ OPBPMNPoolController  
 ]
 
 { #category : 'accessing' }
-OPBPMNGatewayControllerTest >> modelClass [
-	^ OPBPMNGatewayModel 
+OPBPMNGatewayControllerTest >> creationTargetModelClass [
+	^ OPBPMNPoolModel 
 ]
 
 { #category : 'accessing' }
-OPBPMNGatewayControllerTest >> targetControllerClass [
-	^ OPBPMNPoolController  
+OPBPMNGatewayControllerTest >> diagramElementClass [
+	^ OPBPMNGatewayShape
 ]
 
 { #category : 'accessing' }
-OPBPMNGatewayControllerTest >> targetModelClass [
-	^ OPBPMNPoolModel 
+OPBPMNGatewayControllerTest >> modelClass [
+	^ OPBPMNGatewayModel 
 ]