User Services #573

navi-desu · 2022-12-29T06:13:20Z

Hello! This is the start of a draft for supporting user services.

The current "design" works by basically mimicking the layout of the system services.
This commit is the start of the proof of concept, based on what was talked on #432.

I'm opening this draft PR early to ask for some comments and a bit of guidance (since is this my first patch contributing to any project!), and to track progress of the feature.

The current implementation for paths is not that great IMO but I failed to think of a better one.
This also only includes librc, some other utilities are accessing the define'd variables and thus are broken in this patch, but I was able to get rc-update and rc-status, and to an extend, rc-service too, working as things is (granted I created the files in .config manually).
Once a better implementation is decided (or if this one is deemed ideal) I'll patch every file needed and run the tests properly.

The current implementation checks for the callers euid in order to toggle to user mode. If this is not desirable, we could instead introduce subcommands or flags in the commands themselves (rc-update user add <service> for example)

I am also still not familiar with openrc-run, so more study on that and the possible syntax for user service files is needed.

In resume, the idea is to have user-specific runtimes, limited to the users home folder, and tracked by the user (either via PAM, by running the openrc command manually to set the runlevel or other method).

If this feature is wanted, I'm willing to keep developing it and maintaining it for as long as necessary.

Signed-off-by: anna [email protected]

andy5995 · 2023-01-20T05:07:28Z

src/shared/misc.c

+char *
+rc_krunlevel_path_get() {
+	if (!krunlevel_path) {
+		krunlevel_path = xmalloc(sizeof(char) * PATH_MAX);


Hi @anna-cli. One major problem I see is that memory is allocated each time the function is called, but never freed. Or did I miss something?

Hi @anna-cli. One major problem I see is that memory is allocated each time the function is called, but never freed. Or did I miss something?

Hello @andy5995! It shouldn't allocate more than once per function (since the
pointers are global, and there's the check before allocation). But you
made me realise that is probably better to just declare the string as a
static char array inside the function!

N-R-K

Looking at #432 I don't see any of the maintainers making any comment on whether this feature is desired or not.

But just glancing over the diff, I see a decent amount of things which I do not like. I figured I'd leave my comments in here.

But keep in mind that I'm not a maintainer here, so for some of my "larger design related" comments, you probably should wait for a maintainer to comment before acting on it.

src/librc/librc-depend.c

src/shared/misc.c

navi-desu · 2023-03-14T22:20:44Z

Hello again! Last two days I rewrote the whole patchset, and I think it is ready for review! (although there's probably a few mistakes left still).

navi-desu · 2023-03-15T21:41:01Z

@dwfreed @williamh @vapier (CC @thesamesam), Hello! sam recommended I tag one of you, could you check this PR? If it is a desired feature, and if the code overall looks okay!

I am currently daily driving the the patches and looking for bugs and if everything is working too.

navi-desu · 2023-03-16T22:09:49Z

Easy way to test on gentoo:

Add EGIT_OVERRIDE_REPO_OPENRC_OPENRC="https://github.com/navi-desu/openrc" to your make.conf
emerge -1 "=sys-apps/openrc-9999"
Some example scripts are available in here, they should go in ${XDG_CONFIG_DIR}/init.d (defaults to ~/.config/init.d), config files go in ~/.config/conf.d, and the runlevels are created at ~/.config/runlevels. (System-wide services, installed by the package managers will go in /etc/init.d/user.d and /etc/conf.d/user.d)
Then just use normal rc-* commands with the --user flag (or -U). openrc --user default to start the default runlevel (created automatically)

Signed-off-by: Anna (navi) Figueiredo Gomes <[email protected]> Closes: OpenRC#573 Signed-off-by: Sam James <[email protected]>

NyaomiDEV · 2023-04-29T17:32:56Z

This is great! However, have you had any problems with services using D-Bus at all? How would you handle environment exports like that? I am asking since stuff like PipeWire requires it to properly function.

navi-desu · 2023-04-29T18:16:41Z

This is great! However, have you had any problems with services using D-Bus at all? How would you handle environment exports like that? I am asking since stuff like PipeWire requires it to properly function.

for the scripts i wrote so far, only wireplumber needs dbus, a hack to make it work is setting 'rc_env_allow="DBUS_SESSION_BUS_ADDRESS"' in .config/openrc/rc.conf, tho this won't really work when the runlevel is started via PAM (which would be the ideal way to handle that imo).

one thing i'm thinking is making a user init script for a dbus user session, that could be a step to allow the services to see dbus, tho i'm still not sure how to get the var from that into the env of other scripts

NyaomiDEV · 2023-04-29T18:23:27Z

one thing i'm thinking is making a user init script for a dbus user session, that could be a step to allow the services to see dbus, tho i'm still not sure how to get the var from that into the env of other scripts

That's the problem. You should preemptively export DBUS_SESSION_BUS_ADDRESS upon user login to a known value (hint: unix:path=$XDG_RUNTIME_DIR/bus) and then make dbus.user use that environment variable as the path to place the socket (also, being a PAM module I think it'll run early enough that desktop environments can see it, tho my brain is a bit rusty so it's just better to test that hypothesis.)

Now, as for the how, it's up to you; I think you can place it in rc.conf.

Also yes, an accompanying PAM module might be beneficial to the PR. I would suggest looking at https://github.com/chimera-linux/turnstile/blob/master/src/pam_turnstile.cc

Get rid of the alarm/setjmp/longjmp. Trust that the kernel will not block with O_NDELAY. Use write() instead of stdio. Bug: https://bugs.gentoo.org/923326 Signed-off-by: Mike Gilbert <[email protected]>

- Remove 'pkgconfig' subdir - use meson 'pkgconfig' module to generate and install appropriate .pc files when required. - add `rc_path` variable to installed pkgconfig files Signed-off-by: Matt Jolly <[email protected]>

Signed-off-by: Anna (navi) Figueiredo Gomes <[email protected]>

The stop schedule code calls syslog, so we need to open a syslog connection so the process name will get properly logged on musl, and we can ensure the pid gets logged and the right facility is used.

Signed-off-by: Anna (navi) Figueiredo Gomes <[email protected]>

some services might expect to be in home, and may behave unexpectedly for the user, e.g. any program started via dbus, and this matches systemd-user behaviour. Signed-off-by: Anna (navi) Figueiredo Gomes <[email protected]>

Signed-off-by: Anna (navi) Figueiredo Gomes <[email protected]>

navi-desu · 2024-07-23T02:04:08Z

superseded by #723 for the sole reason of github doesn't let me change the source branch of a pr (seriously gh??)

navi-desu force-pushed the master branch 3 times, most recently from c664da6 to 52a6b29 Compare January 19, 2023 01:34

andy5995 reviewed Jan 20, 2023

View reviewed changes

navi-desu force-pushed the master branch from 8e81d83 to 722c59a Compare January 20, 2023 12:06

N-R-K suggested changes Mar 1, 2023

View reviewed changes

navi-desu force-pushed the master branch 5 times, most recently from c89ba7d to 8cf077a Compare March 8, 2023 15:23

navi-desu force-pushed the master branch 3 times, most recently from 7436c74 to dec4e6a Compare March 14, 2023 22:15

navi-desu marked this pull request as ready for review March 14, 2023 22:22

navi-desu requested a review from N-R-K March 14, 2023 22:26

navi-desu force-pushed the master branch 2 times, most recently from f035ad9 to b27b375 Compare March 15, 2023 17:05

navi-desu force-pushed the master branch 4 times, most recently from 114eea7 to be062d4 Compare March 22, 2023 02:17

thesamesam pushed a commit to thesamesam/openrc that referenced this pull request Mar 22, 2023

openrc: Add the correct path for logs as user

5820066

Signed-off-by: Anna (navi) Figueiredo Gomes <[email protected]> Closes: OpenRC#573 Signed-off-by: Sam James <[email protected]>

navi-desu force-pushed the master branch from be062d4 to 85f9d31 Compare April 19, 2023 00:23

floppym and others added 27 commits July 20, 2024 15:09

openrc-shutdown: simplify broadcast function

3586a89

Get rid of the alarm/setjmp/longjmp. Trust that the kernel will not block with O_NDELAY. Use write() instead of stdio. Bug: https://bugs.gentoo.org/923326 Signed-off-by: Mike Gilbert <[email protected]>

Generate pkg-config files directly

1485cfb

- Remove 'pkgconfig' subdir - use meson 'pkgconfig' module to generate and install appropriate .pc files when required. - add `rc_path` variable to installed pkgconfig files Signed-off-by: Matt Jolly <[email protected]>

shared/plugin.c: fix incompatible function warning.

15de84d

Signed-off-by: Anna (navi) Figueiredo Gomes <[email protected]>

start-stop-daemon: open syslog

e46a163

The stop schedule code calls syslog, so we need to open a syslog connection so the process name will get properly logged on musl, and we can ensure the pid gets logged and the right facility is used.

openrc-run.c: allow --user on shebangs

26314e9

Signed-off-by: Anna (navi) Figueiredo Gomes <[email protected]>

support: add user.d examples

9432319

Signed-off-by: Anna (navi) Figueiredo Gomes <[email protected]>

user-guide.md add user-services documentation

df50d89

Signed-off-by: Anna (navi) Figueiredo Gomes <[email protected]>

librc.c: use rc_runlevel_dir for rc_service_add

e849ef3

Signed-off-by: Anna (navi) Figueiredo Gomes <[email protected]>

openrc-pam: fix session count logic

9cde77f

Signed-off-by: Anna (navi) Figueiredo Gomes <[email protected]>

openrc-pam: do not start a login shell

d5ebe7c

Signed-off-by: Anna (navi) Figueiredo Gomes <[email protected]>

openrc-pam: add logging

e29e284

Signed-off-by: Anna (navi) Figueiredo Gomes <[email protected]>

openrc-pam: use full path to mark the service

0fb6b73

Signed-off-by: Anna (navi) Figueiredo Gomes <[email protected]>

librc.c: return "none" from rc_runlevel_get when in user mode.

6b0d03e

Signed-off-by: Anna (navi) Figueiredo Gomes <[email protected]>

version 0.60-beta

7de84f2

Signed-off-by: Anna (navi) Figueiredo Gomes <[email protected]>

meson.build: restore pkg-config filename to openrc.pc

99a5507

Signed-off-by: Anna (navi) Figueiredo Gomes <[email protected]>

openrc-run: fix check for argument count

980bfe6

Signed-off-by: Anna (navi) Figueiredo Gomes <[email protected]>

version 0.60-beta2

255138d

Signed-off-by: Anna (navi) Figueiredo Gomes <[email protected]>

user_init.c: use a single argument for -c

0dcc569

Signed-off-by: Anna (navi) Figueiredo Gomes <[email protected]>

user_init.c: set HOME

12b194b

Signed-off-by: Anna (navi) Figueiredo Gomes <[email protected]>

user_init.c: set SHELL

8e25129

Signed-off-by: Anna (navi) Figueiredo Gomes <[email protected]>

user-init.sh: print message on error

dce704d

Signed-off-by: Anna (navi) Figueiredo Gomes <[email protected]>

rc.c: remove superuser error message

232c398

Signed-off-by: Anna (navi) Figueiredo Gomes <[email protected]>

version 0.60-beta3

fdb1d0d

Signed-off-by: Anna (navi) Figueiredo Gomes <[email protected]>

openrc-run: chdir into HOME for user services.

53de57e

some services might expect to be in home, and may behave unexpectedly for the user, e.g. any program started via dbus, and this matches systemd-user behaviour. Signed-off-by: Anna (navi) Figueiredo Gomes <[email protected]>

rc-logger.c: fix log path for user-mode

6221248

Signed-off-by: Anna (navi) Figueiredo Gomes <[email protected]>

update readme

056f6df

Signed-off-by: Anna (navi) Figueiredo Gomes <[email protected]>

user-init.c: redirect stdin to /dev/null and start a login shell

114bf66

Signed-off-by: Anna (navi) Figueiredo Gomes <[email protected]>

navi-desu closed this Jul 23, 2024

WhyNotHugo mentioned this pull request Sep 5, 2024

User Services 2.0 #723

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

User Services #573

User Services #573

navi-desu commented Dec 29, 2022

andy5995 Jan 20, 2023

navi-desu Jan 20, 2023

N-R-K left a comment

navi-desu commented Mar 14, 2023

navi-desu commented Mar 15, 2023

navi-desu commented Mar 16, 2023

NyaomiDEV commented Apr 29, 2023 •

edited

Loading

navi-desu commented Apr 29, 2023

NyaomiDEV commented Apr 29, 2023 •

edited

Loading

navi-desu commented Jul 23, 2024

User Services #573

User Services #573

Conversation

navi-desu commented Dec 29, 2022

andy5995 Jan 20, 2023

Choose a reason for hiding this comment

navi-desu Jan 20, 2023

Choose a reason for hiding this comment

N-R-K left a comment

Choose a reason for hiding this comment

navi-desu commented Mar 14, 2023

navi-desu commented Mar 15, 2023

navi-desu commented Mar 16, 2023

NyaomiDEV commented Apr 29, 2023 • edited Loading

navi-desu commented Apr 29, 2023

NyaomiDEV commented Apr 29, 2023 • edited Loading

navi-desu commented Jul 23, 2024

NyaomiDEV commented Apr 29, 2023 •

edited

Loading

NyaomiDEV commented Apr 29, 2023 •

edited

Loading