Skip to content

Commit

Permalink
fix: container repository name must be lowercase
Browse files Browse the repository at this point in the history
  • Loading branch information
rwaffen committed Jan 17, 2025
1 parent eceabf2 commit c5aabc8
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 12 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/build_docker.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,13 +44,13 @@ jobs:
build_context: openvoxserver
buildfile: openvoxserver/Containerfile
tags: |
ghcr.io/OpenVoxProject/openvoxserver:${{ matrix.server_version }}-${{ github.ref_name }}
ghcr.io/OpenVoxProject/openvoxserver:${{ matrix.server_version }}-latest
ghcr.io/OpenVoxProject/openvoxserver:latest
ghcr.io/openvoxproject/openvoxserver:${{ matrix.server_version }}-${{ github.ref_name }}
ghcr.io/openvoxproject/openvoxserver:${{ matrix.server_version }}-latest
ghcr.io/openvoxproject/openvoxserver:latest
# - name: Update Docker Hub Description for shortname
# uses: peter-evans/dockerhub-description@v4
# with:
# username: voxpupulibot
# password: ${{ secrets.DOCKERHUB_BOT_PASSWORD }}
# repository: OpenVoxProject/openvoxserver
# repository: openvoxproject/openvoxserver
12 changes: 6 additions & 6 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
- [Version schema](#version-schema)
- [Configuration](#configuration)
- [Initialization Scripts](#initialization-scripts)
- [Persistance](#persistance)
- [Persistence](#persistence)
- [How to Release the container](#how-to-release-the-container)
- [How to contribute](#how-to-contribute)

Expand All @@ -22,7 +22,7 @@ This project hosts the Containerfile and the required scripts to build a OpenVox
You can run a copy of Puppet Server with the following Docker command:

```bash
podman run --name openvox --hostname openvox ghcr.io/OpenVoxProject/openvoxserver:8.8.0-latest
podman run --name openvox --hostname openvox ghcr.io/openvoxproject/openvoxserver:8.8.0-latest
```

Although it is not strictly necessary to name the container `openvox`, this is
Expand All @@ -33,7 +33,7 @@ If you would like to start the OpenVox Server with your own Puppet code, you can
mount your own directory at `/etc/puppetlabs/code`:

```shell
podman run --name openvox --hostname openvox -v ./code:/etc/puppetlabs/code ghcr.io/OpenVoxProject/openvoxserver:8.8.0-latest
podman run --name openvox --hostname openvox -v ./code:/etc/puppetlabs/code ghcr.io/openvoxproject/openvoxserver:8.8.0-latest
```

For compose file see: [CRAFTY](https://github.com/voxpupuli/crafty/tree/main/puppet/oss)
Expand Down Expand Up @@ -126,22 +126,22 @@ You can also create sub-directories in `/docker-custom-entrypoint.d/` for script
- `/docker-custom-entrypoint.d/sigterm-handler/` - scripts that run when the container receives a SIGTERM signal.
- `/docker-custom-entrypoint.d/post-execution/` - scripts that run after the openvoxserver service has stopped.

## Persistance
## Persistence

If you plan to use the in-server CA, restarting the container can cause the server's keys and certificates to change, causing agents and the server to stop trusting each other.
To prevent this, you can persist the default cadir, `/etc/puppetlabs/puppetserver/ca`.
For example:

```shell
podman run -v $PWD/ca-ssl:/etc/puppetlabs/puppetserver/ca ghcr.io/voxpupuli/puppetserver:8.6.1-latest
podman run -v $PWD/ca-ssl:/etc/puppetlabs/puppetserver/ca ghcr.io/openvoxproject/openvoxserver:8.6.1-latest
```

or in compose:

```yaml
services:
puppet:
image: ghcr.io/OpenVoxProject/openvoxserver:8.8.0-latest
image: ghcr.io/openvoxproject/openvoxserver:8.8.0-latest
# ...
volumes:
- ./ca-ssl:/etc/puppetlabs/puppetserver/ca
Expand Down
2 changes: 0 additions & 2 deletions openvoxserver/Containerfile
Original file line number Diff line number Diff line change
Expand Up @@ -80,8 +80,6 @@ ADD https://s3.osuosl.org/puppet-artifacts/openvox-server/${OPENVOXSERVER_VERSIO
ADD https://s3.osuosl.org/puppet-artifacts/openvox-agent/${OPENVOXAGENT_VERSION}/openvox-agent_${OPENVOXAGENT_VERSION}-1%2Bubuntu24.04_${TARGETARCH}.deb /
ADD https://s3.osuosl.org/puppet-artifacts/openvoxdb/${OPENVOXDB_VERSION}/openvoxdb-termini_${OPENVOXDB_VERSION}-1%2Bubuntu24.04_all.deb /

RUN ls -la /

RUN groupadd -g ${OPENVOX_USER_GID} puppet && \
useradd -m -u ${OPENVOX_USER_UID} -g puppet puppet && \
chmod +x /docker-entrypoint.sh /healthcheck.sh /docker-entrypoint.d/*.sh && \
Expand Down

0 comments on commit c5aabc8

Please sign in to comment.