more inclusive issue-notify, do stuff there not ci.yml

PDLPorters · Dec 7, 2024 · ecc0789 · ecc0789
1 parent 2f9b863
commit ecc0789
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 12 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -6,20 +6,10 @@ on:
     tags-ignore:
       - '*'
   pull_request:
-  create:
 
 jobs:
-  notify:
-    runs-on: ubuntu-latest
-    continue-on-error: true
-    if: ${{ always() }}
-    steps:
-      - uses: PDLPorters/devops/github-actions/irc-notifications@master
-        with:
-          target-notifications: true
   ci:
     runs-on: ${{ matrix.os }}
-    if: ${{ github.event_name == 'push' || github.event_name == 'pull_request' }}
     strategy:
       fail-fast: false
       matrix:

diff --git a/.github/workflows/issue-notify.yml b/.github/workflows/issue-notify.yml
@@ -6,10 +6,14 @@ on:
   issue_comment:
     types: [created]
   pull_request:
-    types: [closed,assigned,converted_to_draft,ready_for_review,review_requested]
   pull_request_review:
     types: [submitted]
-
+  push:
+    branches:
+      - '*'
+    tags-ignore:
+      - '*'
+  create:
 jobs:
   notify:
     runs-on: ubuntu-latest