Skip to content

Commit

Permalink
fix unnecessary type-specs that cause problems for Inplace - PDLPorte…
Browse files Browse the repository at this point in the history
  • Loading branch information
mohawk2 committed Dec 27, 2024
1 parent a87b631 commit a9a9f87
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 10 deletions.
1 change: 1 addition & 0 deletions Changes
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
- moved TS::diff (unused here) to Ufunc
- move PDL::Stats::Distr into PDL::GSL since needs GSL
- minimum 5.16 as some 5.15 broke PDL::Stats (https://github.com/Perl/perl5/issues/11835)
- fix unnecessary type-specs that cause problems for Inplace (https://github.com/PDLPorters/pdl/issues/511)

0.84 2024-05-27
- effect_code exception if only one unique value
Expand Down
20 changes: 10 additions & 10 deletions GLM/glm.pd
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ pp_addhdr('
);

pp_def('fill_m',
Pars => 'a(n); float+ [o]b(n)',
Pars => 'a(n); [o]b(n)',
Inplace => 1,
GenericTypes => [F, D],
HandleBad => 1,
Expand Down Expand Up @@ -165,7 +165,7 @@ The output pdl badflag is cleared.
);

pp_def('dev_m',
Pars => 'a(n); float+ [o]b(n)',
Pars => 'a(n); [o]b(n)',
Inplace => 1,
GenericTypes => [F, D],
HandleBad => 1,
Expand All @@ -191,7 +191,7 @@ Replaces values with deviations from the mean. Can be done inplace.
);

pp_def('stddz',
Pars => 'a(n); float+ [o]b(n)',
Pars => 'a(n); [o]b(n)',
Inplace => 1,
GenericTypes => [F, D],
HandleBad => 1,
Expand Down Expand Up @@ -221,7 +221,7 @@ Standardize ie replace values with z_scores based on sample standard deviation f
);

pp_def('sse',
Pars => 'a(n); b(n); float+ [o]c()',
Pars => 'a(n); b(n); [o]c()',
GenericTypes => [F, D],
HandleBad => 1,
Code => '
Expand All @@ -240,7 +240,7 @@ Sum of squared errors between actual and predicted values.
);

pp_def('mse',
Pars => 'a(n); b(n); float+ [o]c()',
Pars => 'a(n); b(n); [o]c()',
GenericTypes => [F, D],
HandleBad => 1,
Code => '
Expand All @@ -262,7 +262,7 @@ Mean of squared errors between actual and predicted values, ie variance around p
);

pp_def('rmse',
Pars => 'a(n); b(n); float+ [o]c()',
Pars => 'a(n); b(n); [o]c()',
GenericTypes => [F, D],
HandleBad => 1,
Code => '
Expand All @@ -284,7 +284,7 @@ Root mean squared error, ie stdv around predicted value.
);

pp_def('pred_logistic',
Pars => 'a(n,m); b(m); float+ [o]c(n)',
Pars => 'a(n,m); b(m); [o]c(n)',
GenericTypes => [F, D],
HandleBad => 1,
Code => '
Expand Down Expand Up @@ -312,7 +312,7 @@ Calculates predicted prob value for logistic regression.
);

pp_def('d0',
Pars => 'a(n); float+ [o]c()',
Pars => 'a(n); [o]c()',
GenericTypes => [F, D],
HandleBad => 1,
Code => '
Expand Down Expand Up @@ -343,7 +343,7 @@ Null deviance for logistic regression.
);

pp_def('dm',
Pars => 'a(n); b(n); float+ [o]c()',
Pars => 'a(n); b(n); [o]c()',
GenericTypes => [F, D],
HandleBad => 1,
Code => '
Expand All @@ -370,7 +370,7 @@ Model deviance for logistic regression.
);

pp_def('dvrs',
Pars => 'a(); b(); float+ [o]c()',
Pars => 'a(); b(); [o]c()',
GenericTypes => [F, D],
HandleBad => 1,
Code => '
Expand Down

0 comments on commit a9a9f87

Please sign in to comment.