-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Type-selection of xform is wrong when has complex
Pars, and converted [o]
Pars in flowing xforms don't work
#511
Comments
mohawk2
added a commit
that referenced
this issue
Dec 20, 2024
mohawk2
added a commit
to mohawk2/perl-PDL-IO-Touchstone
that referenced
this issue
Dec 20, 2024
mohawk2
added a commit
to PDLPorters/perl5-PGPLOT
that referenced
this issue
Dec 20, 2024
mohawk2
added a commit
to mohawk2/PDL-HMM
that referenced
this issue
Dec 20, 2024
mohawk2
added a commit
to jlapeyre/PDL-Fit-Levmar
that referenced
this issue
Dec 20, 2024
mohawk2
added a commit
to EntropyOrg/p5-Data-Frame
that referenced
this issue
Dec 20, 2024
mohawk2
added a commit
to mohawk2/perl5-Test2-Tools-PDL
that referenced
this issue
Dec 20, 2024
mohawk2
added a commit
that referenced
this issue
Dec 20, 2024
mohawk2
added a commit
to mohawk2/Photonic
that referenced
this issue
Dec 20, 2024
mohawk2
added a commit
to mohawk2/Photonic
that referenced
this issue
Dec 20, 2024
mohawk2
added a commit
that referenced
this issue
Dec 20, 2024
mohawk2
added a commit
that referenced
this issue
Dec 22, 2024
mohawk2
added a commit
that referenced
this issue
Dec 22, 2024
mohawk2
changed the title
Type-detection is wrong for
Type-selection of xform is wrong when has Dec 22, 2024
complex
Pars, and converted [o]
Pars in flowing transforms don't workcomplex
Pars, and converted [o]
Pars in flowing xforms don't work
mohawk2
added a commit
that referenced
this issue
Dec 23, 2024
mohawk2
added a commit
that referenced
this issue
Dec 23, 2024
mohawk2
added a commit
that referenced
this issue
Dec 23, 2024
mohawk2
added a commit
that referenced
this issue
Dec 24, 2024
mohawk2
added a commit
that referenced
this issue
Dec 26, 2024
mohawk2
added a commit
that referenced
this issue
Dec 26, 2024
mohawk2
added a commit
that referenced
this issue
Dec 26, 2024
mohawk2
added a commit
that referenced
this issue
Dec 26, 2024
mohawk2
added a commit
that referenced
this issue
Dec 26, 2024
mohawk2
added a commit
that referenced
this issue
Dec 26, 2024
mohawk2
added a commit
that referenced
this issue
Dec 26, 2024
mohawk2
added a commit
that referenced
this issue
Dec 26, 2024
mohawk2
added a commit
that referenced
this issue
Dec 26, 2024
mohawk2
added a commit
that referenced
this issue
Dec 26, 2024
mohawk2
added a commit
that referenced
this issue
Dec 26, 2024
mohawk2
added a commit
that referenced
this issue
Dec 26, 2024
mohawk2
added a commit
that referenced
this issue
Dec 27, 2024
mohawk2
added a commit
to PDLPorters/PDL-Complex
that referenced
this issue
Dec 27, 2024
mohawk2
added a commit
to PDLPorters/PDL-Stats
that referenced
this issue
Dec 27, 2024
mohawk2
added a commit
that referenced
this issue
Dec 27, 2024
mohawk2
added a commit
that referenced
this issue
Dec 27, 2024
mohawk2
added a commit
that referenced
this issue
Dec 27, 2024
mohawk2
added a commit
that referenced
this issue
Dec 27, 2024
mohawk2
added a commit
that referenced
this issue
Dec 27, 2024
mohawk2
added a commit
that referenced
this issue
Dec 28, 2024
mohawk2
added a commit
that referenced
this issue
Dec 28, 2024
Closed
mohawk2
added a commit
to mohawk2/PDL-Cluster
that referenced
this issue
Dec 29, 2024
moocow-the-bovine
added a commit
to moocow-the-bovine/PDL-Cluster
that referenced
this issue
Dec 29, 2024
Pass in right type to [o] Par - PDLPorters/pdl#511
mohawk2
added a commit
that referenced
this issue
Dec 30, 2024
mohawk2
added a commit
that referenced
this issue
Jan 1, 2025
mohawk2
added a commit
that referenced
this issue
Jan 2, 2025
mohawk2
added a commit
that referenced
this issue
Jan 2, 2025
This was referenced Jan 3, 2025
Closed
mohawk2
added a commit
that referenced
this issue
Jan 5, 2025
mohawk2
added a commit
that referenced
this issue
Jan 6, 2025
mohawk2
added a commit
that referenced
this issue
Jan 6, 2025
mohawk2
added a commit
that referenced
this issue
Jan 6, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is discussed in https://pdl.perl.org/advent/blog/2024/12/20/pdl-internals/
Type selection
type_coerce
. As noted in the article above, the type-detection should correctly detect including forcomplex
Pars, though that should be fixed last after the other issue.null
) outputs, any non-available-typed input will select last-given-type, not an available-typed input type (see github actions failing under PDL-2.096 moocow-the-bovine/PDL-CCS#18 (comment) for test case)Type conversion
pdl_converttypei_new
would be called with the ndarray params the non-usual way round, with the inputnull
'sdatatype
being set to the xform's, and the output being the original supplied input.trans_parent
, this would instead cause an error.null
being passed to[io]
Pars.xform inputs from Perl values being made into ndarrays too soon, and thus having a type assigned that requires converting
readdata
(backward dataflow wouldn't make sense) that only processed PerlSV
s, which would avoid overhead in the Perl-value-only scenario (and allow removing thePMCode
forlog10
).Other thoughts
redodims
/readdata
/writebackdata
functions, they should merge theindx
and eitherlong
orlonglong
case, since they are functionally identical and it's a bit less code to generate.[o]
OtherPars should be copied into stack vars at the start of r/w functions, and be forced as rvalues.The text was updated successfully, but these errors were encountered: