-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace egrep with grep -E in Makefile #2316
Merged
larsbrinkhoff
merged 2 commits into
PDP-10:master
from
stevefalco:replace_egrep_with_grep
Jun 16, 2024
Merged
Replace egrep with grep -E in Makefile #2316
larsbrinkhoff
merged 2 commits into
PDP-10:master
from
stevefalco:replace_egrep_with_grep
Jun 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That's a good idea. However, would you mind adding a line like |
stevefalco
force-pushed
the
replace_egrep_with_grep
branch
from
June 15, 2024 19:36
49a0ff4
to
0383511
Compare
On 6/15/24 12:52 PM, Lars Brinkhoff wrote:
That's a good idea. However, would you mind adding a line like |EGREP ?= grep -E| with the others near the top, and use that in the check-dirs target? No need to make a new pull request, you can amend the commit and force push to update this pull request.
Done. Thanks for the suggestion.
I made a similar "egrep => grep -E" change for the ka10-simh and simh repos (in file sim_ether.c) and created PRs for them upstream. Those projects don't use the same override mechanism, though, so I just made the changes directly. Please let me know if you'd like a different approach for that.
I believe you control ka10-simh but I don't know if you have commit rights on simh, BTW.
The only other change I have outstanding is in pdp6 to fix a compile error - I had announced that one a week or two ago, and I've requested it to go upstream: aap/pdp6#32
Steve
|
Thanks, this looks good now! |
larsbrinkhoff
approved these changes
Jun 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fedora 40 gives deprecation warnings on the use of egrep. Replacing "egrep" with "grep -E" in the Makefile is functionally equivalent and eliminates the warnings.