Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace egrep with grep -E in Makefile #2316

Merged
merged 2 commits into from
Jun 16, 2024

Conversation

stevefalco
Copy link
Contributor

Fedora 40 gives deprecation warnings on the use of egrep. Replacing "egrep" with "grep -E" in the Makefile is functionally equivalent and eliminates the warnings.

@larsbrinkhoff
Copy link
Member

That's a good idea. However, would you mind adding a line like EGREP ?= grep -E with the others near the top, and use that in the check-dirs target? No need to make a new pull request, you can amend the commit and force push to update this pull request.

@stevefalco
Copy link
Contributor Author

stevefalco commented Jun 15, 2024 via email

@larsbrinkhoff
Copy link
Member

Thanks, this looks good now!

@larsbrinkhoff larsbrinkhoff merged commit d468a47 into PDP-10:master Jun 16, 2024
8 checks passed
@stevefalco stevefalco deleted the replace_egrep_with_grep branch June 16, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants