Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a HOSTS3 entry for the gateway IP. #2339

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Conversation

bictorv
Copy link
Contributor

@bictorv bictorv commented Sep 13, 2024

This is needed to make COMSAT parse the IP address properly (see #2338): the GW address must have a host entry to be parseable by NETRTS"HANLYZ.

Without the HOSTS3 entry, parsing e.g. "192.168.0.45" fails. With the generated entry, it succeeds.

I'd say the underlying bug is in NETRTS or RESOLV (which is called by NETRTS), but that's for another day.

@eswenson1
Copy link
Member

This is needed even if you use the @192.168.0.45 syntax? It seemed to work for me without that. I did add host table entries for my gateway, but I thought I did that only for aesthetics and only after I verified that it was working. I could be wrong. In any case, is is a good idea to add the host table entries and use symbolic names.

This is needed to make COMSAT parse the IP address properly.
@larsbrinkhoff
Copy link
Member

Squashed.

@bictorv
Copy link
Contributor Author

bictorv commented Sep 16, 2024

This is needed even if you use the @192.168.0.45 syntax? It seemed to work for me without that.

Yes. It didn't seem to work for me. Running with DEBUG non-zero shows debug printouts in STATS, and stepping it shows that HANLYZ (in NETRTS) returns failure.

@larsbrinkhoff larsbrinkhoff merged commit 2d1b8c6 into master Sep 17, 2024
14 checks passed
@larsbrinkhoff larsbrinkhoff deleted the bv/comsat-mchn-gw branch September 17, 2024 06:34
@larsbrinkhoff
Copy link
Member

Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants