Dockerize + Discord Webhook #17
Conversation
- Added Docker support.
To do this I had to
1) Move config.json and auth.json to a separate directory (data).
2) Remove forced UI interaction, and instead use the --account flag to access the account manager. The UI interaction made it impossible to automate, and I found this to be the easiest solution. Maybe adding a print statement to use the flag if you want to access account manager on each boot would be nice
3) Publish my own Docker package on DockerHub. Feel free to publish your own image if you want to. I took the time to use buildx to have multi-arch support, so that shouldn't be an issue either :)
- Discord Webhook Support
I only added this for the auth token expiring, as for password resets you get emails. It's quite annoying having the auth token expire and not knowing
- Added a requirements.txt
This wasn't really necessary, but it is common courtesy for Python projects
|
Full list of requirements already in PR #14 |
|
Discord webhook options? |
|
Requirements in #14 is inaccurate, it lists 3 extra dependencies all 3 of which are pre-installed with Python. I also only saw your Discord Webhook PR after implementing mine, sorry |
Ah. Didn't realise the 3 dependencies were core packages. In regards to the webhooks: your implementation of it is very smart as my PR doesn't log auth errors. I think maybe an option in config of choosing full logging (#12) or choose token expiration logging (#17). That would give the user a nice choice. |
|
Error only vs full seems like a better solution to me. Auth errors were just the most important to me |
|
Yeah sounds good. |
|
meh as long as we have a cool fork its all good. personally i dont really want to work on this anymore as it works fine for my use case, but if you submit a PR ill add it to the docker image |
|
Yeah. If I get round to it I'll work on it but I'm not too bothered. |
|
Awesome. Lmk when you commit it and I'll take the changes and add them the Docker image. Feel free to also steal my changes in my fork (Dockerfile, etc) and put them in yours. If you do that just mention me in the commit / add me as a contributor :) |
|
Thanks. I might yoink some of your code for my fork but I'll give you proper credit for it :) |
Very very dirty fix, but I'm too lazy and it works.
Added Docker support.
To do this I had to:
Discord Webhook Support
I only added this for the auth token expiring, as for password resets you get emails. It's quite annoying having the auth token expire and not knowing
Added a requirements.txt
This wasn't really necessary, but it is common courtesy for Python projects