Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix loraga merge #9765

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

greycooker
Copy link
Contributor

Before submitting

  • Lint code. If there are lint issues, please format the code first.
# Install and register `pre-commit` in the project folder
pip install pre-commit && pre-commit install

# Process previous code files separately
pre-commit run --file XXXX.py
  • Add test cases into tests folder. If there are codecov issues, please add tests cases first.

PR types

Bug fixes

PR changes

APIs

Description

修复LoRA-GA参数保存时的符号问题

@greycooker greycooker mentioned this pull request Jan 9, 2025
2 tasks
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 52.37%. Comparing base (55e7e33) to head (13ff061).
Report is 7 commits behind head on develop.

Files with missing lines Patch % Lines
paddlenlp/peft/lora/lora_model.py 0.00% 7 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #9765      +/-   ##
===========================================
- Coverage    52.41%   52.37%   -0.04%     
===========================================
  Files          729      727       -2     
  Lines       118158   115160    -2998     
===========================================
- Hits         61929    60312    -1617     
+ Misses       56229    54848    -1381     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants