Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better async #431

Merged
merged 10 commits into from
May 22, 2024
Merged

Better async #431

merged 10 commits into from
May 22, 2024

Conversation

martindstone
Copy link

This PR fixes a number of issues related to async behavior:

  • fix merge behavior by chunking large requests (API errors on large batches)
  • disallow marges that would result in >1000 alerts in an incident
  • don't dismiss merge modal until merge is finished, show progress indicator on merge API requests
  • move polling from app component interval timers to sagas
  • implement oauth token refresh
  • add error handling for more API and data structure errors
  • add error tracking for more errors
  • add auto-reload of app on catastrophic errors
  • show log entry polling status, last attempted/completed time and latest log entry time in detailed status overlay

@martindstone martindstone requested a review from gsreynolds April 29, 2024 17:32
Copy link
Member

@gsreynolds gsreynolds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

@gsreynolds gsreynolds merged commit 07ee3c0 into develop May 22, 2024
15 checks passed
@gsreynolds gsreynolds deleted the better-async branch May 22, 2024 15:34
@gsreynolds gsreynolds added this to the v0.13.0 milestone Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants