Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve column filters #443

Merged
merged 5 commits into from
Jun 13, 2024
Merged

improve column filters #443

merged 5 commits into from
Jun 13, 2024

Conversation

martindstone
Copy link

add an indicator with a clear button when there are column filters; indicate when no incidents match filters; stop polling when too many incidents

…ndicate when no incidents match filters; stop polling when too many incidents
@martindstone martindstone requested a review from gsreynolds June 6, 2024 01:01
Copy link
Member

@gsreynolds gsreynolds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

Screenshot 2024-06-13 at 10 24 46

…ency from datadog-ci -> ssh2 -> cpu-features doesn't seem to like the Cypress test image

Signed-off-by: Gavin Reynolds <[email protected]>
@gsreynolds gsreynolds force-pushed the improve-filters branch 4 times, most recently from d30aed5 to e54e503 Compare June 13, 2024 11:11
Signed-off-by: Gavin Reynolds <[email protected]>
@gsreynolds gsreynolds merged commit eb7ca7b into develop Jun 13, 2024
15 checks passed
@gsreynolds gsreynolds deleted the improve-filters branch June 13, 2024 11:43
@gsreynolds gsreynolds added this to the v0.13.0 milestone Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants