forked from giranm/pd-live-react
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for computed columns #463
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
gsreynolds
commented
Jul 11, 2024
•
edited
Loading
edited
- Add additional test for existing column generator functionality
- Add regex-single and regex test for hostname in incident details
- Add computed null condition tests
- Add computed columns UI
- Reduce duplication of values/ids/labels etc so they are defined in fewer places
- Clear Local Cache should really clear local storage and session storage entirely
- Ensure value is loaded from saved columns and ensure expression and expressionType are persisted as needed to set the accessor function
- Remove redundant aggregator from alert columns, always null
- Add validation to add column functions and set default state of columnType
- react-table requires id, but derive it now from value and not accessor if id is not directly set
- Column IDs are now the full value and not just the accessor
- Add e2e test for adding computed columns
- Update locales
- Remove duplicated functions
- Pass custom column as argument and construct value later. Improve e2e tests for alert and computed columns
- Guard against computed or alert column state being undefined
Signed-off-by: Gavin Reynolds <[email protected]>
Signed-off-by: Gavin Reynolds <[email protected]>
Signed-off-by: Gavin Reynolds <[email protected]>
Signed-off-by: Gavin Reynolds <[email protected]>
Signed-off-by: Gavin Reynolds <[email protected]>
gsreynolds
force-pushed
the
computed-columns
branch
from
July 12, 2024 09:04
26286e5
to
5325b73
Compare
Signed-off-by: Gavin Reynolds <[email protected]>
Signed-off-by: Gavin Reynolds <[email protected]>
…wer places Signed-off-by: Gavin Reynolds <[email protected]>
…rage entirely Signed-off-by: Gavin Reynolds <[email protected]>
…ionType is persisted and loaded Signed-off-by: Gavin Reynolds <[email protected]>
gsreynolds
force-pushed
the
computed-columns
branch
from
July 12, 2024 10:54
5325b73
to
adeef0d
Compare
Signed-off-by: Gavin Reynolds <[email protected]>
…nType Signed-off-by: Gavin Reynolds <[email protected]>
…r if id is not directly set Signed-off-by: Gavin Reynolds <[email protected]>
Signed-off-by: Gavin Reynolds <[email protected]>
Signed-off-by: Gavin Reynolds <[email protected]>
Signed-off-by: Gavin Reynolds <[email protected]>
Signed-off-by: Gavin Reynolds <[email protected]>
Signed-off-by: Gavin Reynolds <[email protected]>
…he accessor function Signed-off-by: Gavin Reynolds <[email protected]>
… tests for alert and computed columns Signed-off-by: Gavin Reynolds <[email protected]>
Signed-off-by: Gavin Reynolds <[email protected]>
Signed-off-by: Gavin Reynolds <[email protected]>
martindstone
approved these changes
Jul 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great
Signed-off-by: Gavin Reynolds <[email protected]>
gsreynolds
force-pushed
the
computed-columns
branch
from
July 23, 2024 17:19
86e826a
to
073e65e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.