Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create ffmpeg 5.1.2 for panopto #9

Draft
wants to merge 3 commits into
base: panopto/5.1.2
Choose a base branch
from

Conversation

adaviding
Copy link

@adaviding adaviding commented Feb 2, 2023

  • tfs-124575

@zacrumford
Copy link

Look what I am still getting messages for.

You should prob purge public refs to private repos from your PR description.

@adaviding @jhanners-panopto look, I can still tag you too!

@adaviding
Copy link
Author

@zacrumford I'm not sure what it means to "purge public refs to private repos". Can you try accessing the other 2 PRs and leave comments there? Let me know what happens.

@zacrumford
Copy link

@adaviding in the end, Idk. That said, you should prob care still. I was insinuating that the links in the PR description give out resource locations to panopto internal locations. Even though they are behind a firewall (tfs) or access controlled (panopto-core) you should still avoid leaking them because IF there is a period where the internal resource is accidentally exposed then It can be easily discovered.

Knowing is half the battle.

@adaviding
Copy link
Author

@zacrumford The piece of information that I was missing is that this repo is public. I did not know that.

I modified the PR description to be minimal.

@adaviding adaviding changed the title Create the panopto build of ffmpeg 5.1.2 Create ffmpeg 5.1.2 for panopto Feb 2, 2023
@@ -0,0 +1,168 @@
/*
* DShow Structure Definition Copies
* Copyright (c) 2017 Dsessions
Copy link
Author

@adaviding adaviding Feb 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@derek-se I think I should change this to a Panopto copyright (for all files in this PR). What do you think?

@zacrumford
Copy link

Yup, y'all ship lgpl code with changes so it needs to have a public repo with the changes you ship.

@adaviding adaviding force-pushed the ding/5.1.2/tfs-124575 branch from a40ce85 to 96adea6 Compare February 2, 2023 17:26
@adaviding adaviding force-pushed the ding/5.1.2/tfs-124575 branch from 024e154 to 0f6af14 Compare February 2, 2023 17:31
@adaviding adaviding requested a review from a team February 14, 2023 16:59
@adaviding adaviding marked this pull request as draft February 14, 2023 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants