Firefox support #15
Open
Firefox support #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g. Ctrl), but that modifier key is not in use by LiuChan, LiuChan would still try to interpret the key. For example, user wishes to copy (Ctrl+C) some text, does not have Ctrl as a modifier key. Then LiuChan would (before this fix) interpret the pressed C to copy the dictionary text, when really user expects the behaviour of Ctrl+C not to be changed.
…u3107\u3128\u311b). fixes Paperfeed#12
… android yet however
|
Since I'm not sure if you're still maintaining this extension or if you're interested in maintaining a firefox version yourself, I went ahead and published this on the Firefox add-on marketplace at https://addons.mozilla.org/en-US/firefox/addon/liuchan/ if you want to maintain it yourself let me know. |
|
Hi Geza, I am still maintaining my add-on.
In fact, I've been refactoring the "legacy" code to be more
readable/modular/testable so that I more easily push out updates quickly
without having to worry about introducing a bunch of new bugs, this is also
why I haven't accepted the pull requests yet.
Firefox support is part of the next release.
Thank you for the bug fixes! I'll be sure to include them. I'll accept the
pull requests as I implement the changes!
…On Mon, Sep 17, 2018, 04:27 Geza Kovacs ***@***.***> wrote:
Since I'm not sure if you're still maintaining this extension or if you're
interested in maintaining a firefox version yourself, I went ahead and
published this on the Firefox add-on marketplace at
https://addons.mozilla.org/en-US/firefox/addon/liuchan/ if you want to
maintain it yourself let me know.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#15 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABj8V4w7MyXpe1XunHxgkeCm1NrSFaaFks5ubwiVgaJpZM4WrGbS>
.
|
|
Awesome, happy to hear you're still maintaining this! Note for firefox support that this pull request only covers desktop firefox; I tried getting it working on firefox for android (which should in principle be implementable; this similar extension https://addons.mozilla.org/en-US/firefox/addon/zhongwen-chinese-english/ works on firefox) but it was a pain to debug as there are a few features missing in android ( https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/Differences_between_desktop_and_Android ) so getting full firefox support (including android) may be a bit more work than this pull request suggests. |
|
Getting this to work on Android would be quite a nice feature actually!
I'll look into it. Having everything refactored should help with supporting
different platforms as well :)
…On Mon, Sep 17, 2018, 12:34 Geza Kovacs ***@***.***> wrote:
Awesome, happy to hear you're still maintaining this! Note for firefox
support that this pull request only covers desktop firefox; I tried getting
it working on firefox for android (which should in principle be
implementable; this similar extension
https://addons.mozilla.org/en-US/firefox/addon/zhongwen-chinese-english/
works on firefox) but it was a pain to debug as there are a few features
missing in android (
https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/Differences_between_desktop_and_Android
) so getting full firefox support (including android) may be a bit more
work than this pull request suggests.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#15 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABj8V51b6zaoqGyrJd5qMYIjhmB8xKA1ks5ub3qdgaJpZM4WrGbS>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out this extension can be made to work on firefox with some very trivial changes (see the last commit - 5817b3f ).