Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linking [macOS]; fix compiling for aarch64 #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ichordev
Copy link

No description provided.

@ParticlePeter
Copy link
Owner

ParticlePeter commented Apr 18, 2023

Hi, sorry for the late reply, not much time for my pet project. I noticed your PR ParticlePeter/ErupteD#27 as well, but yes, here is the right place to post them. Before noticing the issue I updated V-Erupt and ErupteD. Unfortunately I'm having some conflicts which I need to sort out. If you like the contribution credits, please update your PR to V-Erupt v1.2.0. Otherwise I can just add the changes myself, they will be reflected in the next ErupteD version after v2.1.97+v1.3.247.
P.S. I don't understand your reasoning for the _handle vs _T issue (will still accept it, it's the same on C side), In which scenario could C++ mangling ever be of interest for a C binding?

@ichordev
Copy link
Author

I don’t mind being credited or not in particular.
I am using this library in my C++ bindings of ImGui with the Vulkan renderer, but the incorrect symbol name caused me mangling issues here: https://github.com/ichordev/bindbc-imgui/blob/master/source/imgui/impl.d#L164

@ParticlePeter
Copy link
Owner

Ah, ok, wrapped my head around it, yeah, that's an unfortunate usecase. So ok, I'll add the fixes to the next vulkan version.
Btw, are you aware of this ImGui DPort? It's an actual full D port, not a binding.

@ichordev
Copy link
Author

Btw, are you aware of this ImGui DPort? It's an actual full D port, not a binding.

Yeah. It doesn’t support very many backends, and a full D translation of an actively maintained library requires significantly more maintenance than a set of bindings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants