-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete Time.h #98
base: master
Are you sure you want to change the base?
Delete Time.h #98
Conversation
remove Time.h because it conflicts with time.h on file systems with case-insensitive filenames, e.g. Windows
@PaulStoffregen this is a good idea |
@michaelmargolis - thoughts on this? How about published books using Time.h vs TimeLib.h in example code? |
This causes me lots of problems. If this sort of change cannot be made to this library for the benefit of lots of future users, then the only alternative may be forking it. |
I am currently working on a hardware project. No changes will happen with this library or any others I maintain until June 2019. Sorry, I need to pay the bills now (so I can do more open source stuff in the future). I've been burned many times before when making "trivial" changes to software without proper testing. Not going to do down the road again. Remind me about this next summer. |
@jamesmyatt For the time being you could use my fork |
@michaelmargolis - What is the situation with printed books in circulation? Will removing Time.h break examples? How much legacy from the old days are we facing? |
This can finally be closed: b0cfc3c |
remove Time.h because it conflicts with time.h on file systems with case-insensitive filenames, e.g. Windows