Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] 이동봉사자 마이페이지 프로필 수정 API 로직 변경 #128

Merged
merged 1 commit into from
Nov 19, 2023
Merged

[Feature] 이동봉사자 마이페이지 프로필 수정 API 로직 변경 #128

merged 1 commit into from
Nov 19, 2023

Conversation

hojeong2747
Copy link
Member

💡 연관된 이슈

close #127

📝 작업 내용

  • 이동봉사자 마이페이지 프로필 수정 API 로직 변경

💬 리뷰 요구 사항

닉네임 값이 변경 되었을 때만 업데이트 되도록 수정했습니다!

@hojeong2747 hojeong2747 added ✨ Feature 기능 개발 Priority: Medium 우선순위 중간 🐰 Hojeong 담당자 labels Nov 19, 2023
kyeong-hyeok
kyeong-hyeok approved these changes Nov 19, 2023
View reviewed changes
Copy link
Member

@kyeong-hyeok kyeong-hyeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

프로필 수정 시 기존 닉네임을 그대로 사용할 경우를 따로 처리하고, 닉네임이 바뀐 경우에는 검증을 처리하는 거 좋은 것 같습니다! 수고하셨습니다 👍

@hojeong2747 hojeong2747 merged commit dac8334 into develop Nov 19, 2023
1 check passed
@hojeong2747 hojeong2747 deleted the feat/127-patch-mypage-profile-api branch November 19, 2023 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyeong-hyeok kyeong-hyeok kyeong-hyeok approved these changes

Assignees
No one assigned
Labels
✨ Feature 기능 개발 🐰 Hojeong 담당자 Priority: Medium 우선순위 중간
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] 이동봉사자 마이페이지 프로필 수정 API 로직 변경
2 participants
@hojeong2747 @kyeong-hyeok