[Feature] 이동봉사자, 이동봉사 중개 봉사 완료 목록 조회 API 구현 #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
hojeong2747
approved these changes
Nov 16, 2023
| .join(application.post.dog, dog) | ||
| .join(application.volunteer, volunteer) | ||
| .leftJoin(review).on(post.id.eq(review.post.id)) | ||
| .leftJoin(dogStatus).on(post.id.eq(dogStatus.post.id)) |
There was a problem hiding this comment.
QueryDsl에서 innerJoin만 많이 쓰다 보니까 조인의 기본 개념을 잊고 있었나봐요.
leftJoin이 필요한 표본 데이터셋이라고 생각이 드네요.
원하는 값을 가져오기 위해 현재 상황에 맞게 leftJoin 생각하고 활용한 점 완전 최고입니다! 👍👍👍
There was a problem hiding this comment.
쿼리 고민하면서 성능 개선하는 거 재미있는 거 같아요 ~~ !
호정님이 깊게 고민하는 과정을 보고 저도 다시 한 번 생각하게 됐습니다! 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 연관된 이슈
close #76
📝 작업 내용
💬 리뷰 요구 사항
저희가 놓치는 부분이 있었던 것 같습니다!
해당 테이블에 다른 테이블의 외래키가 존재하지 않더라도 join으로 조건을 추가해서 가져온다면 쿼리를 더 줄일 수 있을 것 같아요.
다른 API도 리팩토링 하면서 성능을 개선해 나가면 좋을 것 같습니다!