-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix use of session_id
in collect_data
#909
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #909 +/- ##
==========================================
+ Coverage 44.23% 45.84% +1.60%
==========================================
Files 66 65 -1
Lines 9839 9725 -114
Branches 1097 1063 -34
==========================================
+ Hits 4352 4458 +106
+ Misses 5263 5040 -223
- Partials 224 227 +3 ☔ View full report in Codecov by Sentry. |
@@ -226,6 +230,11 @@ def collect_data(bids_dir, participant_label, session_id=None, filters=None, bid | |||
for dtype, query in queries.items() | |||
} | |||
|
|||
config.loggers.workflow.log( | |||
25, | |||
f'Collected data:\n{yaml.dump(subj_data, default_flow_style=False, indent=4)}', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
THANK YOU
Closes #908.
collect_data
wasn't usingsession_id
except when there's a BIDS filter field.Changes proposed in this pull request
collect_data
's handling ofsession_id
.