refactoring of the ssh module to separate auth check / cmd checks #292
+89
−82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikaiw
requested review from
zblurx,
Marshall-Hallenbeck,
NeffIsBack and
mpgn
as code owners
|
Thanks fot the contribution! Fyi, i changed the target branch to main |
|
@nikaiw can you undo the black formatting? |
|
should be better I hope |
|
Thanks for the work 🙂 |
|
@nikaiw can you run Ruff and fix any issues? |
|
@Marshall-Hallenbeck yes, done. Sry actually I did it previously but I guess not with the latest ruff version. It should be better now |
|
@nikaiw it looks like this is based of the old dev branch and is therefore quite outdated. |
|
Fyi: gonna close this PR in favour of #331 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.