Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#IMP-036: update Codeblock #119

Merged
merged 8 commits into from
Nov 27, 2024
Merged

Conversation

Pet3r1512
Copy link
Owner

No description provided.

@Pet3r1512 Pet3r1512 requested a review from Copilot November 27, 2024 09:14
Copy link

vercel bot commented Nov 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
dev-initer ✅ Ready (Inspect) Visit Preview Nov 27, 2024 9:15am

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 4 changed files in this pull request and generated no suggestions.

Files not reviewed (2)
  • src/pages/tech/prisma.mdx: Language not supported
  • src/pages/tech/vitest.mdx: Language not supported
Comments skipped due to low confidence (2)

src/components/Documents/CodeBlock.tsx:8

  • The 'filename' prop should have a default value or type check to ensure it's a string.
filename,

src/components/Documents/CodeBlock.tsx:48

  • [nitpick] The 'iconSize' prop is set to 18 here, but it's 24 by default in the 'CopyButton' component. Ensure consistency.
<CopyButton iconSize={18} copyContent={code} />
@Pet3r1512 Pet3r1512 merged commit 10ac3f8 into master Nov 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant