-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Orphans for V2 #684
Orphans for V2 #684
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, some questions only
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what happens when you generate some TxInfo fields
data TxInfo = TxInfo
{ txInfoInputs :: [TxInInfo] -- ^ NON EMPTY Map TxOutRef TxInInfo (NOT A LIST)
, txInfoReferenceInputs :: [TxInInfo] -- ^ Same as above
, txInfoOutputs :: [TxOut] -- ^ Anything goes but Value must have positive ADA
, txInfoFee :: Value -- ^ This MUST be ONLY ADA
, txInfoMint :: Value -- ^ This contains 0 ADA
, txInfoDCert :: [DCert] -- ^ Not sure but I suspect this is also a Map of sorts
, txInfoWdrl :: Map StakingCredential Integer
, txInfoValidRange :: POSIXTimeRange -- ^ End MUST be after begginning (shock and disbelief).
, txInfoSignatories :: [PubKeyHash] -- ^ This is NOT a LIST this is a Set PubKeyHash
, txInfoRedeemers :: Map ScriptPurpose Redeemer
, txInfoData :: Map DatumHash Datum
, txInfoId :: TxId
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TxInfo list/map/set invariants are missing right? You want to add these in some other PR?
Closes #681. This will need to be updated in PR #679 for V3 versions of the types in question.