Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

583 Fix M.core_formchangechecker is undefined #584

Closed

Conversation

leonstr
Copy link
Contributor

@leonstr leonstr commented Jul 26, 2024

Migrate moodle-core-formchangechecker to core_form/changechecker as the former was removed in Moodle 4.3.3 (MDL-72308).

Proposed fix for #583

Copy link
Contributor

@mchurchward mchurchward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this. Can you rebase with the latest MOODLE_401_STABLE to re-enable the CI tests?

Also, will this change allow this to function on Moodle 4.0 and up?

Migrate moodle-core-formchangechecker to core_form/changechecker as the
former was removed in Moodle 4.3.3 (MDL-72308).
@leonstr leonstr force-pushed the 583-formchangechecker branch from c2b42f4 to 51fc3bd Compare August 22, 2024 16:13
@leonstr
Copy link
Contributor Author

leonstr commented Aug 22, 2024

Rebased.

Also, will this change allow this to function on Moodle 4.0 and up?

Yes, the new core_form/changechecker was added in Moodle 4.0 (MDL-69918).

@mchurchward
Copy link
Contributor

Your PR still includes commits from other changes than this one. The PR needs to just include the commit(s) for this PR.
You need to pull the latest MOODLE_401_STABLE locally, then rebase your branch on top of that.
You may need to remove commits that are not part of your PR? Possibly you included some from a different PR?

@mchurchward
Copy link
Contributor

Ah. Sorry. I did fix this here. Thanks for your fix as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants