Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ineffective --component-url serve cli option #3496

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix ineffective --component-url serve cli option #3496

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/cli/src/commands/serve.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ export class ServeCommand implements Command {
npm: config.npm,
moduleResolution: config.moduleResolution,
componentDir: config.componentDir,
componentUrl: options['component-url'],
packageName: options['package-name'],
protocol: options['protocol'],
keyPath: options['key'],
Expand All @@ -91,7 +92,7 @@ export class ServeCommand implements Command {

if (serverInfos.kind === 'mainline') {
const mainlineServer = serverInfos;
const urls = getServerUrls(options, mainlineServer.server);
const urls = getServerUrls(serverOptions, mainlineServer.server);
logger.info(
`Files in this directory are available under the following URLs
applications: ${url.format(urls.serverUrl)}
Expand All @@ -100,7 +101,7 @@ export class ServeCommand implements Command {
} else {
// We started multiple servers, just tell the user about the control
// server, it serves out human-readable info on how to access the others.
const urls = getServerUrls(options, serverInfos.control.server);
const urls = getServerUrls(serverOptions, serverInfos.control.server);
logger.info(`Started multiple servers with different variants:
View the Polyserve console here: ${url.format(urls.serverUrl)}`);
}
Expand Down