Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add wrapper support PostHogMaskWidget for Flutter widgets #153

Merged
merged 7 commits into from
Jan 16, 2025
Merged

feat: add wrapper support PostHogMaskWidget for Flutter widgets #153

merged 7 commits into from
Jan 16, 2025

Conversation

thisames
Copy link
Contributor

@thisames thisames commented Jan 14, 2025 •
edited
Loading

💡 Motivation and Context

#137

💚 How did you test it?

when

config.sessionReplayConfig.maskAllTexts = false;
config.sessionReplayConfig.maskAllImages = false;
2025-01-14.11-52-09.mp4

when

config.sessionReplayConfig.maskAllTexts = true;
config.sessionReplayConfig.maskAllImages = true;
2025-01-14.12-14-03.mp4

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • I updated the docs if needed.
  • No breaking change or entry added to the changelog.

@thisames thisames marked this pull request as ready for review January 15, 2025 15:02
@marandaneto
Copy link
Member

@thisames after 3 more comments and LGTM
Also you can rename the PR title now, thanks and great work.

@thisames thisames changed the title feat: add wrapper support PostHogNoMaskWidget for Flutter widgets feat: add wrapper support PostHogMaskWidget for Flutter widgets Jan 15, 2025
@marandaneto
Copy link
Member

I pushed a few fixes 9db9d98 (#153)

@marandaneto marandaneto merged commit a4f25ce into PostHog:main Jan 16, 2025
@marandaneto marandaneto mentioned this pull request Jan 16, 2025
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marandaneto marandaneto marandaneto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thisames @marandaneto