chore(ci): prettier & always include latest built version #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pauldambra
changed the title
|
What does "code-neutral" mean here? a bit lost with the problem definition so I cannot review if the changes make sense. |
|
it means no functional changes :) |
marandaneto
reviewed
Mar 11, 2024
LICENSE
Outdated
| @@ -1,6 +1,6 @@ | |||
| MIT License | |||
|
|
|||
| Copyright (c) 2020 Weyert de Boer | |||
There was a problem hiding this comment.
I dont think this is allowed, you'd need to keep the original one
https://www.tldrlegal.com/license/mit-license
marandaneto
reviewed
Mar 11, 2024
| import { processEvent } from '../plugin' | ||
| import { processEvent, UserAgentMetaInput } from '../plugin' | ||
|
|
||
| function makeMeta(options?: { |
There was a problem hiding this comment.
Nice refactoring to avoid code dupe.
marandaneto
approved these changes
Mar 11, 2024
pauldambra
commented
Mar 11, 2024
xvello
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a small PR so we can check we can deploy a change that builds the same code as the last version safely
building up confidence for working towards #4