Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sparse matrix error: more complete repro case #854

Merged
merged 2 commits into from
Dec 9, 2024

Conversation

TonyXiang8787
Copy link
Member

@TonyXiang8787 TonyXiang8787 commented Dec 8, 2024

Add a branch measurement also does not help the issue in #853

Signed-off-by: Tony Xiang <[email protected]>
@TonyXiang8787 TonyXiang8787 self-assigned this Dec 8, 2024
@TonyXiang8787 TonyXiang8787 requested a review from mgovers December 8, 2024 18:07
@TonyXiang8787
Copy link
Member Author

@mgovers, the code quality error seems to be un-related. Feel free to fix it.

Copy link
Member

@mgovers mgovers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. FYI: i fixed mypy incompatibility with numpy==2.2.0, which caused the failing CI (both here and in the Nightly). This will also fix the nightly again

Copy link

sonarqubecloud bot commented Dec 9, 2024

@TonyXiang8787 TonyXiang8787 added this pull request to the merge queue Dec 9, 2024
Merged via the queue into main with commit 45cc5f9 Dec 9, 2024
29 checks passed
@TonyXiang8787 TonyXiang8787 deleted the bug/sparse-matrix-error-more-repro branch December 9, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants