Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements and Fixes #15

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Improvements and Fixes #15

wants to merge 16 commits into from

Conversation

Wolf2323
Copy link

@Wolf2323 Wolf2323 commented Apr 16, 2024 •
edited
Loading

The fork contains multiple improvements and fixes, that i needed.

@Wolf2323 Wolf2323 marked this pull request as draft April 16, 2024 13:14
@Wolf2323 Wolf2323 marked this pull request as ready for review April 16, 2024 13:44
@Kesuaheli Kesuaheli mentioned this pull request Apr 16, 2024
Open
Wolf2323 and others added 13 commits April 22, 2024 16:02
@Wolf2323
added PowerCameraFinishEvent to the stop method of a camera
d8bf71e
@Wolf2323
added reload command to reload the config
a9aa266
@inkarkat
TASK-4714 Build: Use the MavenSetup parent
de8bd47 
Add our repository and the required distributionManagement config, drop the maven-compiler-plugin config that's now inherited.
@inkarkat
TASK-4714 Build: Refactoring: Use canonical Maven structure with src/…
6f4f926 
…main/{java,resources}

With this, we don't need the sourceDirectory override and custom resources config in the POM any longer.
@inkarkat
TASK-4714 Housekeeping: Removed: Eclipse config
ff92bb8 
All of that can be imported from the POM.
@inkarkat
TASK-4714 Renaming: Move PowerCamera/ contents up into the root
79f71d4 
This is a single-module project, no need for a subdir, and this gets rid of the duplicated .gitignore, too.
Our MavenSetup currently expects the POM in the project root.
@inkarkat
TASK-4714 Style: Suppress all PMD violations
25ed598
@inkarkat
TASK-4714 Style: Suppress all SpotBugs violations
d33b96c
@inkarkat
TASK-4714 Style: Address EditorConfig and CheckStyle violations
4139ad4 
To avoid reformatting all whitespace, instead a custom EditorConfig specifies 4-space indent for Java files instead of our tabstop-based indentation.
Likewise, a CheckStyle suppression disables our custom Indentation rule.
@inkarkat
TASK-4714 Housekeeping: Consistency: Use our .gitignore, add our .git…
4f9a1ff 
…attributes

So that files are checked out with Unix-style line endings on Windows as well.
@inkarkat
TASK-4714 Build: Housekeeping: Add MavenSetup plugin build, Dependabo…
4236348 
…t, and PR template
@inkarkat
TASK-4714 Build: Housekeeping: Add Maven Wrapper and extension settings
3b711ba
@inkarkat
TASK-4714 Build: Use the MavenSetup parent and suppress style-related…
5bded98 
… warnings

Integrated via #1

Merge branch 'TASK-4714/build/MavenSetup'
@inkarkat inkarkat deleted the branch PowerNetworkHub:master July 24, 2024 13:59
@inkarkat inkarkat deleted the master branch July 24, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rotation does not always rotate correctly Add reload command to get updates from file
2 participants
@Wolf2323 @inkarkat