Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the OS Platform information in telemetry #278

Merged
merged 3 commits into from
Nov 6, 2024
Merged

Add the OS Platform information in telemetry #278

merged 3 commits into from
Nov 6, 2024

Conversation

NoriZC
Copy link
Contributor

@NoriZC NoriZC commented Nov 6, 2024 •
edited
Loading

PR Summary

  • Updated the telemetry functionality by adding information about the operating system platform.
  • Extracted GetInstallationId() and GetOSPlatform() to make the initialize() more readable.
  • TODO: Update the connect string for app insights. Will do tomorrow when I get my SAW on hand to access AME env.

PR Context

@daxian-dbw
Copy link
Member

@NoriZC Feel free to submit another PR to update the connection string.

@daxian-dbw daxian-dbw merged commit 907b270 into PowerShell:main Nov 6, 2024
4 checks passed
@daxian-dbw daxian-dbw changed the title Add OS Platform Infromation in Telemetry Add the OS Platform information in telemetry Nov 6, 2024
@NoriZC NoriZC deleted the telemetry branch November 7, 2024 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daxian-dbw daxian-dbw daxian-dbw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NoriZC @daxian-dbw