Refactor Codebase to Use Symfony Filesystem Instead of Native PHP Functions #1109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
M0rgan01
force-pushed
the
Filesystem-refacto
branch
7 times, most recently
from
d9b2502 to
0c9d13d
Compare
M0rgan01
force-pushed
the
Filesystem-refacto
branch
2 times, most recently
from
210af31 to
52308ff
Compare
M0rgan01
changed the title
ga-devfront
reviewed
Jan 10, 2025
Comment on lines
67
to
73
|
|
||
| if ($filesystem->exists($filePath)) { | ||
| if ($this->container->getUpdateConfiguration()->isChannelOnline()) { | ||
| try { | ||
| $filesystem->remove($filePath); | ||
| $this->logger->debug($this->translator->trans('%s removed', [$filePath])); | ||
| } catch (Exception $e) { |
There was a problem hiding this comment.
I'm not sure but I think you can use IOExceptionInterface from symfony filesystem.
Comment on lines
82
to
87
| try { | ||
| $filesystem->remove($latestPath); | ||
| $this->logger->debug($this->translator->trans('%s removed', [$latestPath])); | ||
| } catch (Exception $e) { | ||
| $this->logger->debug($this->translator->trans('Please remove %s by FTP', [$latestPath])); | ||
| } |
There was a problem hiding this comment.
you do the same as other try catch what do you think about make a method for it ?
| $this->logger->debug($this->translator->trans('Please remove %s by FTP', [$filePath])); | ||
| } | ||
| } else { | ||
| $this->logger->debug($this->translator->trans('Please remove %s by FTP', [$filePath])); |
There was a problem hiding this comment.
Why we log remove by ftp if we are not on channelOnline ? I'm not sure but I think something is rong her on the refacto.
| $this->next = TaskName::TASK_ERROR; | ||
| $this->logger->error($this->translator->trans('Error while creating directory %s.', [$dest])); | ||
| $this->logger->error($this->translator->trans('Error while creating directory %s: %s.', [$dest, $e->getMessage()])); |
There was a problem hiding this comment.
I'm not sure but I think something is wrong with the translation %s: %s
| $this->next = TaskName::TASK_ERROR; | ||
| $this->logger->error($this->translator->trans('Error while copying file %s', [$file])); | ||
| $this->logger->error($this->translator->trans('Error while copying file %s: %s', [$file, $e->getMessage()])); |
There was a problem hiding this comment.
same for translation her
M0rgan01
force-pushed
the
Filesystem-refacto
branch
3 times, most recently
from
8c6447e to
5af8958
Compare
|
|
M0rgan01
force-pushed
the
Filesystem-refacto
branch
from
5af8958 to
0f6f416
Compare
|
Comment on lines
+68
to
+73
| if (!$this->filesystem->exists($path)) { | ||
| try { | ||
| $this->filesystem->mkdir($path); | ||
| } catch (IOException $e) { | ||
| throw new IOException($this->translator->trans('Unable to create directory %s: %s', [$path, $e->getMessage()])); | ||
| } |
There was a problem hiding this comment.
No need to check anymore if the directory already exists. If it does, Filesystem will ignore the creation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the codebase to replace the usage of native PHP filesystem functions (e.g., file_exists, unlink, mkdir, etc.) with the Symfony Filesystem component. This change improves code readability, consistency, and reliability by leveraging Symfony's robust and well-tested API for filesystem operations.
Key changes include:
This refactor aligns with best practices and enhances compatibility with modern Symfony projects.