Move window topbar content to menu on small screens #1524
gerdesqueAnnotations
12 errors and 1 warning
|
__tests__/src/components/WindowTopBar.test.js > WindowTopBar > uses allow flags to override defaults:
__tests__/src/components/WindowTopBar.test.js#L50
Error: expect(element).not.toBeInTheDocument()
expected document not to contain element, found <button
aria-haspopup="true"
aria-label="Window views & thumbnail display"
class="MuiButtonBase-root MuiIconButton-root MuiIconButton-sizeLarge css-1tjecsd-MuiButtonBase-root-MuiIconButton-root-MiradorMenuButton-root"
data-mui-internal-clone-element="true"
tabindex="0"
type="button"
>
<svg
aria-hidden="true"
class="MuiSvgIcon-root MuiSvgIcon-fontSizeMedium css-1m9ymud-MuiSvgIcon-root"
focusable="false"
height="24"
viewBox="0 0 24 24"
width="24"
xmlns="http://www.w3.org/2000/svg"
>
<path
d="M0,0H24V24H0Z"
fill="none"
/>
<path
d="M24.852,17.981,3,18V15.945l21.852-.019Z"
transform="translate(-2 5)"
/>
<path
d="M1,4V21H22.853V4.1ZM3,19V6h8V19Zm18,0H13V6h8Z"
transform="translate(0 -2)"
/>
</svg>
<span
class="MuiTouchRipple-root css-8je8zh-MuiTouchRipple-root"
/>
</button> instead
❯ __tests__/src/components/WindowTopBar.test.js:50:92
|
|
__tests__/src/components/WindowTopBar.test.js > WindowTopBar > passes correct callback to closeWindow button:
__tests__/src/components/WindowTopBar.test.js#L84
AssertionError: expected "spy" to be called 1 times, but got 0 times
❯ __tests__/src/components/WindowTopBar.test.js:84:26
|
|
__tests__/src/components/WindowTopBar.test.js > WindowTopBar > passes correct callback to maximizeWindow button:
__tests__/src/components/WindowTopBar.test.js#L93
AssertionError: expected "spy" to be called 1 times, but got 0 times
❯ __tests__/src/components/WindowTopBar.test.js:93:28
|
|
__tests__/src/components/WindowTopBar.test.js > WindowTopBar > close button is configurable:
__tests__/src/components/WindowTopBar.test.js#L99
Error: expect(element).not.toBeInTheDocument()
expected document not to contain element, found <button
aria-label="Close window"
class="MuiButtonBase-root MuiIconButton-root MuiIconButton-sizeLarge mirador-window-close mirador-window-menu-btn css-1tjecsd-MuiButtonBase-root-MuiIconButton-root-MiradorMenuButton-root"
data-mui-internal-clone-element="true"
tabindex="0"
type="button"
>
<svg
aria-hidden="true"
class="MuiSvgIcon-root MuiSvgIcon-fontSizeMedium css-i4bv87-MuiSvgIcon-root"
data-testid="CloseSharpIcon"
focusable="false"
viewBox="0 0 24 24"
>
<path
d="M19 6.41 17.59 5 12 10.59 6.41 5 5 6.41 10.59 12 5 17.59 6.41 19 12 13.41 17.59 19 19 17.59 13.41 12z"
/>
</svg>
<span
class="MuiTouchRipple-root css-8je8zh-MuiTouchRipple-root"
/>
</button> instead
❯ __tests__/src/components/WindowTopBar.test.js:99:24
|
|
__tests__/src/components/WindowTopBar.test.js > WindowTopBar > maximize button is configurable:
__tests__/src/components/WindowTopBar.test.js#L105
Error: expect(element).not.toBeInTheDocument()
expected document not to contain element, found <button
aria-label="Maximize window"
class="MuiButtonBase-root MuiIconButton-root MuiIconButton-sizeLarge mirador-window-maximize mirador-window-menu-btn css-1tjecsd-MuiButtonBase-root-MuiIconButton-root-MiradorMenuButton-root"
data-mui-internal-clone-element="true"
tabindex="0"
type="button"
>
<svg
aria-hidden="true"
class="MuiSvgIcon-root MuiSvgIcon-fontSizeMedium css-1m9ymud-MuiSvgIcon-root"
focusable="false"
height="24"
viewBox="0 0 24 24"
width="24"
xmlns="http://www.w3.org/2000/svg"
>
<path
d="M7,14H5v5h5V17H7Zm7-9V7h3v3h2V5Z"
/>
<path
d="M22.517,1.524H1.736V22.37H22.517Zm-2,18.845H3.736V3.524H20.517Z"
/>
</svg>
<span
class="MuiTouchRipple-root css-8je8zh-MuiTouchRipple-root"
/>
</button> instead
❯ __tests__/src/components/WindowTopBar.test.js:105:24
|
|
__tests__/integration/mirador/tests/plugin-add.test.js > add two plugins to <WorkspaceControlPanelButtons> > all add plugins are present:
__tests__/integration/mirador/tests/plugin-add.test.js#L14
TestingLibraryElementError: Found multiple elements with the display value: hello componentD.
Here are the matching elements:
Ignored nodes: comments, script, style
<input
value="hello componentD"
/>
Ignored nodes: comments, script, style
<input
value="hello componentD"
/>
(If this is intentional, then use the `*AllBy*` variant of the query (like `queryAllByText`, `getAllByText`, or `findAllByText`)).
Ignored nodes: comments, script, style
<body
class=""
>
<div>
<div
data-testid="mirador"
style="bottom: 0px; left: 0px; position: absolute; right: 0px; top: 0px;"
>
<div
class="fullscreen"
>
<div
class="css-rvh6fe-WorkspaceArea-root"
>
<nav
aria-label="Workspace navigation"
class="MuiPaper-root MuiPaper-elevation MuiPaper-elevation4 MuiAppBar-root MuiAppBar-colorDefault MuiAppBar-positionAbsolute mirador-workspace-control-panel css-3f7qxr-MuiPaper-root-MuiAppBar-root-WorkspaceControlPanel-root"
>
<div
class="MuiToolbar-root MuiToolbar-regular css-1lartyw-MuiToolbar-root-WorkspaceControlPanel-toolbar"
>
<button
aria-label="Add resource"
class="MuiButtonBase-root MuiFab-root MuiFab-circular MuiFab-sizeMedium MuiFab-primary MuiFab-root MuiFab-circular MuiFab-sizeMedium MuiFab-primary css-18prof-MuiButtonBase-root-MuiFab-root-WorkspaceAddButton-root"
data-mui-internal-clone-element="true"
id="addBtn"
tabindex="0"
type="button"
>
<svg
aria-hidden="true"
class="MuiSvgIcon-root MuiSvgIcon-fontSizeMedium css-i4bv87-MuiSvgIcon-root"
data-testid="AddSharpIcon"
focusable="false"
viewBox="0 0 24 24"
>
<path
d="M19 13h-6v6h-2v-6H5v-2h6V5h2v6h6z"
/>
</svg>
<span
class="MuiTouchRipple-root css-8je8zh-MuiTouchRipple-root"
/>
</button>
<div
class="css-j0aotr-WorkspaceControlPanel-buttonArea"
>
<button
aria-haspopup="true"
aria-label="Jump to window"
class="MuiButtonBase-root MuiIconButton-root MuiIconButton-sizeLarge css-1tjecsd-MuiButtonBase-root-MuiIconButton-root-MiradorMenuButton-root"
data-mui-internal-clone-element="true"
tabindex="0"
type="button"
>
<span
class="MuiBadge-root css-1yq562r-MuiBadge-root"
>
<svg
aria-hidden="true"
class="MuiSvgIcon-root MuiSvgIcon-fontSizeMedium css-i4bv87-MuiSvgIcon-root"
data-testid="BookmarksSharpIcon"
focusable="false"
viewBox="0 0 24 24"
>
<path
d="m19 18 2 1V1H7v2h12zM17 5H3v18l7-3 7 3z"
/>
</svg>
<span
class="MuiBadge-badge MuiBadge-standard MuiBadge-anchorOriginTopRight MuiBadge-anchorOriginTopRightRectangular MuiBadge-overlapRectangular css-dlwkee-MuiBadge-badge"
>
1
</span>
</span>
<span
class="MuiTouchRipple-root css-8je8zh-MuiTouchRipple-root"
/>
</button>
<button
aria-haspopup="true"
aria-label="Workspace settings"
class="MuiButtonBase-root MuiIconButton-root MuiIconButton-sizeLarge css-1tjecsd-MuiButtonBase-root-MuiIconButton-root-MiradorMenuButton-root"
data-mui-internal-clone-element="true"
i
|
|
__tests__/integration/mirador/tests/window-actions.test.js > Window actions > Closes a Mirador window:
__tests__/integration/mirador/tests/window-actions.test.js#L13
Error: expect(element).not.toBeInTheDocument()
expected document not to contain element, found <section
aria-label="Window: Self-Portrait Dedicated to Paul Gauguin"
class="MuiPaper-root MuiPaper-elevation MuiPaper-rounded MuiPaper-elevation1 mirador-window css-170ci9v-MuiPaper-root-Window-root"
id="window-1c7f6aef-c67b-46b0-8de2-6c7ff707823f"
>
<nav
aria-label="Window navigation"
class="MuiPaper-root MuiPaper-elevation MuiPaper-elevation4 MuiAppBar-root MuiAppBar-colorDefault MuiAppBar-positionRelative css-3r04er-MuiPaper-root-MuiAppBar-root-WindowTopBar-root"
>
<div
class="MuiToolbar-root MuiToolbar-dense mirador-window-top-bar css-kqh1n7-MuiToolbar-root-WindowTopBar-toolbar"
>
<button
aria-label="Toggle sidebar"
class="MuiButtonBase-root MuiIconButton-root MuiIconButton-sizeLarge mirador-window-menu-btn css-1tjecsd-MuiButtonBase-root-MuiIconButton-root-MiradorMenuButton-root"
data-mui-internal-clone-element="true"
tabindex="0"
type="button"
>
<svg
aria-hidden="true"
class="MuiSvgIcon-root MuiSvgIcon-fontSizeMedium css-i4bv87-MuiSvgIcon-root"
data-testid="MenuSharpIcon"
focusable="false"
viewBox="0 0 24 24"
>
<path … />
</svg>
<span
class="MuiTouchRipple-root css-8je8zh-MuiTouchRipple-root"
/>
</button>
<div
style="position: absolute; left: 0px; top: 0px; right: 0px; bottom: 0px; overflow: hidden; z-index: -1; visibility: hidden; pointer-events: none;"
>
<div
style="position: absolute; left: 0px; top: 0px; right: 0px; bottom: 0px; overflow: hidden; z-index: -1; visibility: hidden; pointer-events: none;"
>
<div … />
</div>
<div
style="position: absolute; left: 0px; top: 0px; right: 0px; bottom: 0px; overflow: hidden; z-index: -1; visibility: hidden; pointer-events: none;"
>
<div … />
</div>
</div>
<h2
class="MuiTypography-root MuiTypography-h2 MuiTypography-noWrap css-cnazwj-MuiTypography-root"
>
Self-Portrait Dedicated to Paul Gauguin
</h2>
<div
class="css-k008qs"
>
<button
aria-haspopup="true"
aria-label="Window views & thumbnail display"
class="MuiButtonBase-root MuiIconButton-root MuiIconButton-sizeLarge css-1tjecsd-MuiButtonBase-root-MuiIconButton-root-MiradorMenuButton-root"
data-mui-internal-clone-element="true"
tabindex="0"
type="button"
>
<svg … />
<span … />
</button>
<button
aria-label="Maximize window"
class="MuiButtonBase-root MuiIconButton-root MuiIconButton-sizeLarge mirador-window-maximize mirador-window-menu-btn css-1tjecsd-MuiButtonBase-root-MuiIconButton-root-MiradorMenuButton-root"
data-mui-internal-clone-element="true"
tabindex="0"
type="button"
>
<svg … />
<span … />
</button>
<button
aria-label="Close window"
class="MuiButtonBase-root MuiIconButton-root MuiIconButton-sizeLarge mirador-window-close mirador-window-menu-btn css-1tjecsd-MuiButtonBase-root-MuiIconButton-root-MiradorMenuButton-root"
data-mui-internal-clone-element="true"
tabindex="0"
type="button"
>
<svg … />
<span … />
</button>
</div>
</div>
</nav>
<div
class="css-hnlh1b-Window-row"
>
<div
class="css-akjxpj-Window-column"
>
<div
class="mirador-primary-window css-jx6z7x-PrimaryWindow-root-Window-primary"
data-testid="test-window"
>
<div
class="MuiDrawer-root MuiDrawer-docked css-3e6fbi-MuiDrawer-docked-WindowSideBar-root"
/>
<div
class="mirador-companion-area-left css-6xzsnq-CompanionArea-root"
>
<div … />
</div>
<section
aria-label="Item: 3
|
|
build (20.x)
Process completed with exit code 1.
|
|
build (22.x)
The job was canceled because "_20_x" failed.
|
|
build (22.x)
The operation was canceled.
|
|
build (18.x)
The job was canceled because "_20_x" failed.
|
|
build (18.x)
The operation was canceled.
|
|
build (20.x)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|