fix keyboard navigation issues with windowTopMenu #3914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Edit: It seems as the keyboard navigation worked as expected when M3 was still using Material Ui v4. |
gerdesque
previously approved these changes
Jul 9, 2024
cbeer
reviewed
Nov 8, 2024
src/components/WindowViewSettings.js
Outdated
| @@ -63,10 +67,11 @@ export class WindowViewSettings extends Component { | |||
| none of the click handlers work? */ | |||
| const menuItem = ({ value, Icon }) => ( | |||
| <ViewOption | |||
| selected={windowViewType === value} | |||
| key={value} | |||
| aria-selected={windowViewType === value} | |||
There was a problem hiding this comment.
Is aria-selected a valid/useful attribute for menu items? I'm not seeing it on https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/menuitem_role. Maybe this should be a menuitemradio + aria-checked?
There was a problem hiding this comment.
Ah thanks for spotting :)
i added aria-checked and menuitemrole
cbeer
reviewed
Nov 8, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3914 +/- ##
==========================================
+ Coverage 94.52% 94.53% +0.01%
==========================================
Files 313 313
Lines 14767 14798 +31
Branches 2496 2498 +2
==========================================
+ Hits 13958 13989 +31
Misses 804 804
Partials 5 5 ☔ View full report in Codecov by Sentry. |
gerdesque
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
this PR tries to fix the issue described here: #3903
The reason why view and thumbnail options could not be controlled correctly was due to the use of the MUI Menu component and not the wrong TabIndex as described in the issue. The component expects MenuItems as direct children. This was fixed by using a popover instead of the menu, (on which menu is based upon) and setting the MenuLists in WindowViewSettings and WindowThumbnailSettings.