fix:mirador_crash

[fstoe]

I found out that adding something through the add button in the catalog view which is json but not a manifest makes the viewer crash.
steps to reproduce:

• Open Mirador
• Add Resource with example url: https://iiif.io/api/presentation/2/context.json
• Open legit resource

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 94.58%. Comparing base (88cc3f9) to head (c095751).

Files with missing lines	Patch %	Lines
src/state/selectors/manifests.js	66.66%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3927      +/-   ##
==========================================
- Coverage   94.59%   94.58%   -0.01%     
==========================================
  Files         315      315              
  Lines       14759    14762       +3     
  Branches     2490     2490              
==========================================
+ Hits        13961    13963       +2     
- Misses        794      795       +1     
  Partials        4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[lutzhelm]

Hi @fstoe, could you add a test case for that patch? createManifestoInstance itself is not exported, but getManifestoInstance calls it directly, so this would be a good place to add a test:

https://github.com/ProjectMirador/mirador/blob/master/__tests__/src/selectors/manifests.test.js#L56-L68

Something like

it('does not crash if json is not a manifest', () => {
  const state = { manifests: { x: { json: {} } } };
  const received = getManifestoInstance(state, { manifestId: 'x' });
  expect(received).toBe(undefined);
});

[fstoe]

Hey @lutzhelm,
thanks for the comment. I just added a small test case

[lutzhelm]

This test has been removed on main. I don't know the reason, but it's the cause of the current merge conflict. Could you resolve this conflict e.g. by merging main into this branch? Just be sure that the test case actually stays removed.

[fstoe]

Done :)