Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI testing flakiness with interval waiting #4057

Closed
wants to merge 1 commit into from

Conversation

marlo-longley
Copy link
Member

This is happening almost every run...

@marlo-longley marlo-longley force-pushed the flaky-viewer-test branch 2 times, most recently from 1c58af3 to 0f97891 Compare December 17, 2024 21:06
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.51%. Comparing base (41e2a86) to head (42d8df5).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4057   +/-   ##
=======================================
  Coverage   94.51%   94.51%           
=======================================
  Files         313      313           
  Lines       14751    14751           
  Branches     2484     2485    +1     
=======================================
  Hits        13942    13942           
  Misses        804      804           
  Partials        5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marlo-longley marlo-longley force-pushed the flaky-viewer-test branch 3 times, most recently from 0a0ccb3 to 34e239d Compare December 17, 2024 22:55
@cbeer cbeer force-pushed the flaky-viewer-test branch 5 times, most recently from ff9c0ce to 7efbe10 Compare December 18, 2024 16:04
@marlo-longley
Copy link
Member Author

Replaced by Chris's work in #4062

@marlo-longley marlo-longley deleted the flaky-viewer-test branch December 19, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants