Update the LocalePicker to use labels for languages. #4058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbeer
force-pushed
the
manifest-locales-picker
branch
from
896aa56 to
2008133
Compare
cbeer
force-pushed
the
manifest-locales-picker
branch
from
2008133 to
df014ca
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4058 +/- ##
=======================================
Coverage 94.51% 94.52%
=======================================
Files 313 313
Lines 14752 14768 +16
Branches 2486 2494 +8
=======================================
+ Hits 13943 13959 +16
Misses 804 804
Partials 5 5 ☔ View full report in Codecov by Sentry. |
marlo-longley
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... and update it to support IIIF v3.
Before:
After:
Extracted from #4054